Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: working mvp with native BATCH message support #2

Merged
merged 13 commits into from
Oct 28, 2022
Merged

feat: working mvp with native BATCH message support #2

merged 13 commits into from
Oct 28, 2022

Conversation

kgpayne
Copy link
Collaborator

@kgpayne kgpayne commented Sep 27, 2022 •
edited
Loading

@kgpayne kgpayne marked this pull request as ready for review September 28, 2022 16:05
@aaronsteers aaronsteers mentioned this pull request Oct 27, 2022
Open
@aaronsteers
Copy link

@kgpayne - This looks ready to go! But please do go ahead and log any issues that you want to make sure we come back to. Even for SDK upstream changes, you can log an issue here in this repo to get the conversations started - and to represent the work that would be needed after the SDK-side updates.

A huge step from what's on main so I would lean towards a merge this week if we can. 🎉

@edgarrmondragon - Any changes you'd like to see, now, or in an upcoming iteration?

edgarrmondragon
edgarrmondragon requested changes Oct 28, 2022
View reviewed changes
target_snowflake/sinks.py Outdated Show resolved Hide resolved
@edgarrmondragon
Copy link
Member

@kgpayne Just a nit on an unused import, otherwise looks good.

We should probably add pre-commit to lint the repo.

aaronsteers and others added 3 commits October 28, 2022 16:29
@aaronsteers aaronsteers mentioned this pull request Oct 28, 2022
Closed
@aaronsteers
Copy link

@kgpayne Just a nit on an unused import, otherwise looks good.

We should probably add pre-commit to lint the repo.

Logged:

@aaronsteers
Copy link

I'm going to go ahead and merge this, and we can iterate from here.

cc @pnadolny13, @visch, @BuzzCutNorman

Follow-ups are logged in the issue tracker: https://github.com/meltanolabs/target-snowflake/issues

Nice work on this, @kgpayne

@aaronsteers aaronsteers changed the title feat: working mvp feat: working mvp with native BATCH message support Oct 28, 2022
@aaronsteers aaronsteers merged commit a3caa38 into main Oct 28, 2022
@aaronsteers aaronsteers deleted the kgpayne/mvp branch October 28, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsteers aaronsteers aaronsteers approved these changes

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: native Snowflake bulk load for BATCH messages
3 participants
@kgpayne @aaronsteers @edgarrmondragon