fix: limit max length edge case

[pnadolny13]

Closes #67

[edgarrmondragon]

Is there a reason you need to

1. get the max length from the schema
2. check if it's over the max allowed value
3. update in the json schema
4. get the max length again in to_sql_type

Could this be simplified to doing something like

@staticmethod
def get_max_length(jsonschema_type: dict) -> int:
    max_length = jsonschema_type.get("maxLength", self.MAX_COLUMN_SIZE)  # MAX_COLUMN_SIZE could be set on the connector class of each target
    return min(max_length, self.MAX_COLUMN_SIZE)

@staticmethod
def to_sql_type(jsonschema_type: dict) -> sqlalchemy.types.TypeEngine:
    ...
    maxlength = SnowflakeConnector.get_max_length(jsonschema_type)

[pnadolny13]

@edgarrmondragon yeah I did that originally but for this implementation we call the super to_sql_type which ends up overwriting the raw max length value by default. I'm not 100% sure I understand this whole custom type mapping logic here but the test fails unless we either overwrite the jsonschema type or after we call the super we do something like this to fix that length also.

target_type = SQLConnector.to_sql_type(jsonschema_type)
maxlength = SnowflakeConnector.get_max_length(jsonschema_type)
if hasattr(target_type, 'length'):
    target_type.length = maxlength

[edgarrmondragon]

Oh I see, you're right. I missed the call to SQLConnector.to_sql_type. 👍