Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoplay #81

Merged
merged 2 commits into from
Jul 26, 2018
Merged

Autoplay #81

merged 2 commits into from
Jul 26, 2018

Conversation

jbpratt
Copy link
Member

@jbpratt jbpratt commented Jul 25, 2018

Auto-playing services:

  • Angelthump
  • Dailymotion
  • Chaturbate but muted
  • Ustream
  • Vaughn
  • Youtube
  • Youtube playlist

Not auto-playing due to various reasons

  • Facebook
  • Twitch

Removed:

  • Azubu
  • Hitbox & Hitbox-vod
  • Streamup
  • MLG can work but dead platform so scraping. Only one stream live at the time of typing this.

Leaving Afreeca for now

@xDashh
Copy link
Member

xDashh commented Jul 25, 2018

references (or closes)
#22
#66

@xDashh
Copy link
Member

xDashh commented Jul 25, 2018

reminder to probably get rid of the volume param once this is being merged https://github.com/MemeLabs/Rustla2/pull/81/files#diff-ccf8a5cd91493c36de6fded1940cbf99R22

@kenany
Copy link
Member

kenany commented Jul 25, 2018

Can you create a ticket for that?

@slugalisk
Copy link
Member

@jbpratt78 These platforms are also validated by the backend. Could you update these lists too please?

constexpr folly::StringPiece kAdvancedService{"advanced"};
constexpr folly::StringPiece kAfreecaService{"afreeca"};
constexpr folly::StringPiece kAngelThumpService{"angelthump"};
constexpr folly::StringPiece kAzubuService{"azubu"};
constexpr folly::StringPiece kDailyMotionService{"dailymotion"};
constexpr folly::StringPiece kFacebookService{"facebook"};
constexpr folly::StringPiece kHitboxService{"hitbox"};
constexpr folly::StringPiece kHitboxVODService{"hitbox-vod"};
constexpr folly::StringPiece kMLGService{"mlg"};
constexpr folly::StringPiece kNSFWChaturbateService{"nsfw-chaturbate"};
constexpr folly::StringPiece kStreamupService{"streamup"};
constexpr folly::StringPiece kTwitchService{"twitch"};
constexpr folly::StringPiece kTwitchVODService{"twitch-vod"};
constexpr folly::StringPiece kUstreamService{"ustream"};
constexpr folly::StringPiece kVaughnService{"vaughn"};
constexpr folly::StringPiece kYouTubePlaylistService{"youtube-playlist"};
constexpr folly::StringPiece kYouTubeService{"youtube"};
constexpr std::array<folly::StringPiece, 17> kServices{
kAdvancedService, kAfreecaService, kAngelThumpService,
kAzubuService, kDailyMotionService, kFacebookService,
kHitboxService, kHitboxVODService, kMLGService,
kNSFWChaturbateService, kStreamupService, kTwitchService,
kTwitchVODService, kUstreamService, kVaughnService,
kYouTubePlaylistService, kYouTubeService};
constexpr std::array<folly::StringPiece, 4> kCaseInsensitiveServices{
kAngelThumpService, kHitboxService, kTwitchService, kUstreamService};

@jbpratt
Copy link
Member Author

jbpratt commented Jul 25, 2018

@slugalisk Yeah I can do both of these @xDashh

@slugalisk
Copy link
Member

@jbpratt78 It looks like your new revision replaced the frontend changes... You probably still have the previous revision locally (the hash was ccf8a5cd91493c36de6fded1940cbf99R22) so you should be able to rebase it onto your autoplay branch and push it to add it to the pr.

@slugalisk slugalisk merged commit 9d9b398 into MemeLabs:master Jul 26, 2018
@slugalisk
Copy link
Member

@jbpratt78 thanks 👍

@jbpratt jbpratt deleted the autoplay branch August 5, 2018 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants