Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing key props #669

Merged
merged 3 commits into from
Jul 15, 2023
Merged

Conversation

rosvik
Copy link
Contributor

@rosvik rosvik commented Jul 14, 2023

(Thanks for adding the PR template @sgriff96 😄)

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • [ ] You've discussed making your changes with a member of the dev team per contributing rules in the README (Not a "entirely new feature")
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

Please provide a summary of what your PR does

Got some debug warnings due to missing key props. This PR adds keys to the cases I could find, to suppress the warnings and maybe prevent future bugs and performance issues. The cases were:

  • Trending communities list
  • Community search results
  • User search results
  • App icon selection list
  • Theme selection list

Screenshots

If the UI has been changed, include screenshots.
We will not review your PR without screenshots if they are applicable.

No visual changes

Test Plan

Please document the steps required to test your PR

With debug enabled, verify that none of these cases gives the "Each child in a list should have unique 'key' prop" warning:

  • "Search" tab (trending list is visible)
  • "Search" tab -> search for a community
  • "Search" tab -> search for a user
  • "Profile" tab -> settings -> "Appearance" -> "App Icon"
  • "Profile" tab -> settings -> "Appearance" -> "Theme"

Copy link
Collaborator

@sgriff96 sgriff96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice this has been annoying me but i've been too lazy to fix it

@gkasdorf gkasdorf merged commit 3a1770c into Memmy-App:main Jul 15, 2023
@rosvik rosvik deleted the rosvik/add-missing-key-props branch July 15, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants