Community stats #750
Merged
Community stats #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgriff96
approved these changes
Jul 18, 2023
| <Text fontSize="xl" fontWeight="bold"> | ||
| Stats: | ||
| </Text> | ||
| <HStack flexWrap="wrap"> |
There was a problem hiding this comment.
Suggested change
| <HStack flexWrap="wrap"> | |
| <HStack flexWrap="wrap" space={1}> |
Comment on lines
+14
to
+19
| const subscribers = shortenNumber(counts.subscribers); | ||
| const posts = shortenNumber(counts.posts); | ||
| const comments = shortenNumber(counts.comments); | ||
| const usersActiveMonth = shortenNumber(counts.users_active_month); | ||
| const usersActiveWeek = shortenNumber(counts.users_active_week); | ||
| const usersActiveDay = shortenNumber(counts.users_active_day); |
There was a problem hiding this comment.
@bohn002 we already had this util (but I realized it was broken, so fixed it). Also you named the function (PrettyNumbers) with PascalCase, but non React component functions should be camelCase.
React components - PascalCase
Everything else - camelCase
| import AvatarUsername from "./AvatarUsername"; | ||
|
|
||
| interface IProps { | ||
| item: any; | ||
| moderators: CommunityModeratorView[]; |
There was a problem hiding this comment.
I changed this to just pass the moderators list instead of being for 1 item in the list. Also don't use any if you can. It makes it so typescript just doesn't work, which is not actually helpful generally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Creator Checklist
Ensure you've checked the following before submitting your PR:
Summary
Resolves #670 Adds stats to the Community About page. When a stat gets above or equals 1000, a prettier version of the digit is displayed. So 1,234 is displayed as 1.2k etc.
Screenshots
Test Plan
Open the feed, select a Community. Click "About". Scroll page down to "Stats".