Traverse Rewrite #767
Traverse Rewrite #767
Conversation
This reverts commit b86f4c8.
# Conflicts: # src/components/screens/Traverse/components/TraverseItem.tsx
|
I've now tested this out on an iPad sim and my physical iPhone. I'm happy with how it is at this point so opening it up for full review. The big question is whether we move forward with Gluestack or not. It's...different, but it has similar performance as straight react and makes things a little easier to dev once you figure out its properties. |
|
Before merging can you tweak the header size/style for Favorites and Subscribed to be similar to the section letter dividers? Would also be nice to be able to sort the order of favorites. 😜 |
|
@theycallmebeez If there isn't an issue for the sorting can you add one? That's not trivial to add this go around. I'll talk with the other devs about the header sizing. I'm no designer. |
all done - #772 |
PR Creator Checklist
Ensure you've checked the following before submitting your PR:
Summary
This covers a few tickets, including #736 and #708. I fixed the alpha indexes so they don't show after filtering if there are no items under that index. I also added some spacing above Subscriptions and added counts for Favorites and Subscriptions. These counts update based on the search.
This is a pretty major rewrite of Traverse. I've included Gluestack for the usage of HStack and VStack, but I also let the tool generate other Native Base components that we use so we can replace them over time.
Screenshots
My gif showing performance is too big to put here so I"ll share it in the contributors channel. Here's a screenshot showing the extra padding above Subscriptions along with the count.
Test Plan
Go to traverse. Scroll. Filter. Favorite. Unfavorite. Make sure empty list messages are working.