Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/841 instance reset on restart #852

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

flx-sta
Copy link
Contributor

@flx-sta flx-sta commented Jul 26, 2023

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

fixes #841
Fixes the persistence issue of the filters and improved the components and add some explanation text (de/en)

Screenshots

image

Test Plan

  1. Go to settings
  2. Click on "filters"
  3. Test around in that (both)
  4. Add some keywords and instances to the filter
  5. Close the App
  6. reopen the app
  7. check if any set keywords/instances are still there (persisted)

clean up and generalize filters components
fix some translations and add some UI
@gkasdorf gkasdorf merged commit b958f8e into Memmy-App:main Jul 27, 2023
3 checks passed
@flx-sta flx-sta deleted the bug/841-instance_reset_on_restart branch July 27, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instances added to filter are cleared on app restart
2 participants