Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add clear button to search bar that follows theme colors #855

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

rosvik
Copy link
Contributor

@rosvik rosvik commented Jul 26, 2023

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
    • There are however some errors other places that are not touched by this PR
  • You've tested your changes

Summary

Please provide a summary of what your PR does

closes #597

  • Adds a custom clear button to SearchBox that follows theme colors, in favor of the native one. I tried to keep it functionally identical to the native implementation, but couldn't find a SF icon with a solid background, so that might be the only significant difference.
  • Adds some hitSlop to the clear button and the search field, to make it easier hit.

Screenshots

If the UI has been changed, include screenshots.
We will not review your PR without screenshots if they are applicable.

Simulator.Screen.Recording.-.iPhone.14.-.2023-07-26.at.22.26.29.mp4

Test Plan

Please documemnt the steps required to test your PR

Functionality shown in recording above ^

rosvik and others added 3 commits July 26, 2023 22:20
This adds extra slop on left and right side to allow pressing empty 
areas, as well as a little above and below.
@gkasdorf gkasdorf merged commit 858534d into Memmy-App:main Jul 27, 2023
2 checks passed
@rosvik rosvik deleted the rosvik/add-clear-button branch July 27, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(x) Button in search-bar barely visible in dark mode
2 participants