Fix for issue #13 - Improved story container #19
Conversation
seanprashad
requested review from
seanprashad,
vldmrkl and
Mera-Gangapersaud
There was a problem hiding this comment.
This is G R E A T @deepanjali19! 👏🏽 We have two small things that we can fix up and this should be good to go after that!
Please let us know if anything is unclear 😺
| @@ -28,14 +28,14 @@ class CreativeCollab extends React.Component { | |||
| this.firstEditor = instance; | |||
| }} | |||
| /> | |||
| <div className="story-container" dangerouslySetInnerHTML={{ __html: this.state.story }} /> | |||
There was a problem hiding this comment.
Sweet - the story box is right where it should be 🤠
src/CreativeCollab.css
Outdated
| width: 800px; | ||
| height: 380px; | ||
| height: 340px; | ||
| overflow: scroll; |
There was a problem hiding this comment.
Nice work! We might want to use overflow-y: auto instead as it will automatically show the vertical scroller if the text exceeds the height of the <div>:
You'll also notice that the message wraps to the next line and doesn't show a horizontal scroll bar - let's also add overflow-wrap: break-word; which does just that!
seanprashad
force-pushed
the
deepanjali19/storyContainer
branch
from
413bc52
to
3694f99
Compare
seanprashad
force-pushed
the
deepanjali19/storyContainer
branch
from
3694f99
to
462c428
Compare
There was a problem hiding this comment.
To save @deepanjali19 a very big headache of fixing the package-lock.json problem, I went ahead and update it alongside two things to polish up.
Here's what it looks locally:
The story containers looks neat and is scrollable! Please let me know if you require any changes 👍
Thanks a lot for the opportunity!