Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: enable emf and jpeg figure format #67

Merged
merged 6 commits into from
Dec 3, 2021
Merged

feature: enable emf and jpeg figure format #67

merged 6 commits into from
Dec 3, 2021

Conversation

elong0527
Copy link
Collaborator

  • create fig_format
  • create rtf_read_figure
  • deprecate rtf_read_png
  • update rtf_encode_figure and rtf_figure
  • update example-figure
  • replace rtf_read_png to rtf_read_figure

Yilong Zhang added 2 commits December 1, 2021 19:35
feature: enable emf and jpeg figure format
820287d 
- create fig_format
- create rtf_read_figure
- deprecate rtf_read_png
- update rtf_encode_figure and rtf_figure
- update example-figure
- replace `rtf_read_png` to `rtf_read_figure`
bump version
0ebb3ef
@elong0527 elong0527 mentioned this pull request Dec 2, 2021
Closed
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021 •
edited
Loading

Codecov Report

Merging #67 (0043735) into master (53e795e) will decrease coverage by 0.16%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   93.30%   93.13%   -0.17%     
==========================================
  Files          36       36              
  Lines        1836     1849      +13     
==========================================
+ Hits         1713     1722       +9     
- Misses        123      127       +4
Impacted Files Coverage Δ
R/rtf_encode.R 100.00% <ø> (ø)
R/rtf_figure.R 80.00% <33.33%> (-20.00%) ⬇️
R/rtf_read.R 60.00% <60.00%> (ø)
R/dictionary.R 100.00% <100.00%> (ø)
R/rtf_encode_figure.R 96.22% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e795e...0043735. Read the comment docs.

@nanxstats
Copy link
Collaborator

Can you re-run the two Ubuntu workflows? It looks like a transient connection issues to RSPM.

nanxstats
nanxstats approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me. You should merge after passing the updated actions.

@elong0527 elong0527 merged commit 54da534 into master Dec 3, 2021
@elong0527 elong0527 mentioned this pull request Dec 3, 2021
Closed
@elong0527 elong0527 deleted the fig-format branch February 1, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanxstats nanxstats nanxstats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elong0527 @codecov-commenter @nanxstats