Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #94

Closed
jpvillaisaza opened this issue Sep 1, 2022 · 6 comments · Fixed by #97
Closed

Fix CI #94

jpvillaisaza opened this issue Sep 1, 2022 · 6 comments · Fixed by #97

Comments

@jpvillaisaza
Copy link
Collaborator

CI is out of date. See #93 (comment) for a recommendation to use haskell-ci or switch to GitHub Actions.
@lf-
Copy link
Contributor

lf- commented Sep 19, 2022

I'm working on this right now, as well as nixifying slack-web at Mercury. I also have some further plans with it.

@jpvillaisaza
Copy link
Collaborator Author

@lf- Sounds good, thank you!

@lf-
Copy link
Contributor

lf- commented Sep 21, 2022

I just double checked: @MercuryTechnologies can take over maintainership of the library :)

Due to vagaries of GitHub design, it would need to be transferred to an individual account who is a member of the organization. I would be happy to do this process with my account @LF-, and @avieth could as well.

One of the plans we have is to open source parts of our internal slack integration such as webhooks and a message builder into slack-web.

@lf- lf- mentioned this issue Sep 21, 2022
Closed
@jpvillaisaza
Copy link
Collaborator Author

Do you mean it would need to be transferred first to your account (or the account of someone from Mercury) and then from that account to the Mercury organization?

@lf-
Copy link
Contributor

lf- commented Sep 22, 2022

Do you mean it would need to be transferred first to your account (or the account of someone from Mercury) and then from that account to the Mercury organization?

That's correct, since transferring to an organization requires repository creation permission according to the docs I linked.

@jpvillaisaza jpvillaisaza mentioned this issue Sep 26, 2022
Closed
@jpvillaisaza
Copy link
Collaborator Author

Okay, sounds good! I opened #96 for things related to transferring the library.

@lf- lf- mentioned this issue Sep 28, 2022
Merged
@lf- lf- closed this as completed in #97 Sep 29, 2022
lf- pushed a commit that referenced this issue Sep 29, 2022
@avieth
Make CI work (#97)
b46f7ca 
Same PR as #95 but post repo move

This uses GitHub Actions and haskell-ci. I decided not to figure out
CircleCI.

You do need the latest haskell-ci version from git to be able to
generate for GHC 9.4.2. But it works!

This also builds and tests with GHC 9.4.2 ;-)

It also comes with a bonus Nix flake, because I can't help myself I
guess 😆

Fixes #94

Co-authored-by: Alexander Vieth <aovieth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make CI work MercuryTechnologies/slack-web
Make CI work!
2 participants
@jpvillaisaza @lf-