Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODIFF_makeCopySqlite does not close source DB correctly #132

Closed
wonder-sk opened this issue Jun 24, 2021 · 0 comments · Fixed by #133
Closed

GEODIFF_makeCopySqlite does not close source DB correctly #132

wonder-sk opened this issue Jun 24, 2021 · 0 comments · Fixed by #133
Labels
bug Something isn't working

Comments

@wonder-sk
Copy link
Contributor

If a.gpkg is in WAL mode, running geodiff copy a.gpkg b.gpkg will leave a.gpkg-wal and a.gpkg-shm files when it is finished, so probably it is not closing the source database correctly.

@wonder-sk wonder-sk added the bug Something isn't working label Jun 24, 2021
wonder-sk added a commit that referenced this issue Jun 24, 2021
Even though it is possible to open databases in WAL mode as read-only
since sqlite 3.22 (released in 2018), there seem to be a couple of limitations:
https://sqlite.org/wal.html#readonly

The -wal and -shm are left behind even after the database is closed.
So better let's open it in read/write mode as usual and those files
will get proper treatment - they will be removed when connection is closed.
wonder-sk added a commit that referenced this issue Jun 25, 2021
Even though it is possible to open databases in WAL mode as read-only
since sqlite 3.22 (released in 2018), there seem to be a couple of limitations:
https://sqlite.org/wal.html#readonly

The -wal and -shm are left behind even after the database is closed.
So better let's open it in read/write mode as usual and those files
will get proper treatment - they will be removed when connection is closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant