Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NULL values handled badly when creating changeset for datetime column #154

Closed
wonder-sk opened this issue Nov 3, 2021 · 0 comments · Fixed by #155
Closed

NULL values handled badly when creating changeset for datetime column #154

wonder-sk opened this issue Nov 3, 2021 · 0 comments · Fixed by #155
Labels
bug Something isn't working

Comments

@wonder-sk
Copy link
Contributor

When doing diff on a table with a datetime column, geodiff does not handle NULL values correctly: if one value is null but the other value is not null, geodiff still evaluates it as if there was no change.

Bug introduced in #109
@wonder-sk wonder-sk added the bug Something isn't working label Nov 3, 2021
@wonder-sk wonder-sk mentioned this issue Nov 3, 2021
Closed
wonder-sk added a commit that referenced this issue Nov 4, 2021
@wonder-sk
Fix handling of null/not-null values of datetime type (fixes #154)
57382de 
We weren't handling the case when the old or new value was null and the other wasn't.
In such case, create changeset would omit adding such row to the diff.

The datetime tests were updated to include rows with null datetime values.
wonder-sk added a commit that referenced this issue Nov 4, 2021
@wonder-sk
Fix handling of null/not-null values of datetime type (fixes #154)
ba8f00b 
We weren't handling the case when the old or new value was null and the other wasn't.
In such case, create changeset would omit adding such row to the diff.

The datetime tests were updated to include rows with null datetime values.
@wonder-sk wonder-sk mentioned this issue Nov 4, 2021
Merged
wonder-sk added a commit that referenced this issue Nov 5, 2021
@wonder-sk
Fix handling of null/not-null values of datetime type (fixes #154)
e7bea82 
We weren't handling the case when the old or new value was null and the other wasn't.
In such case, create changeset would omit adding such row to the diff.

The datetime tests were updated to include rows with null datetime values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling of null/not-null values of datetime type MerginMaps/geodiff
1 participant
@wonder-sk