More PostgreSQL datatypes support #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
different drivers (fix #176)
|
best to review by @wonder-sk |
wonder-sk
reviewed
Jul 6, 2022
There was a problem hiding this comment.
Great stuff. One thing I am wondering about is how we deal with "numeric" columns - we store them as doubles which provide 15 to 17 significant decimal digits, but what if someone stores a decimal number with 20 digits, and we would be loosing precision? I guess for now it would be OK if that would be a known limitation, I am just wondering if we can/should trigger some warnings in case we do a conversion where this would happen (i.e. not warn if someone uses numeric(50) with small numbers, only warn with numeric(50) and numbers with 16+ digits?
|
I was thinking about converting |
alexbruy
force-pushed
the
pg-data-types
branch
2 times, most recently
from
1069606
to
e712064
Compare
wonder-sk
reviewed
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for more PostgreSQL datatypes:
character(N)andchar(N)(fixes Error when copying DB to GPKG for datatype character(50) #177)numeric(M, N)uuid(fixes Support for UUID data type in postgres driver #157)Avoid datatypes conversion while making copy of the database if source and destitation drivers are the same. This allows to use native datatypes and avoid conversion issues (fixes #176).