Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open sync failed dialog when "willRetry" notification is clicked #3469

Merged
merged 2 commits into from
May 28, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented May 27, 2024

When a sync error of type "willRetry" (maintenance mode) occurs and its notification is displayed, the syncFailedDialog opens upon clicking it.

PR_3469.mov

Fixes #3451

Copy link

Pull Request Test Coverage Report for Build 9256460431

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.06%) to 59.917%

Files with Coverage Reduction New Missed Lines %
input/core/merginapi.cpp 3 78.58%
input/core/merginuserinfo.cpp 3 73.76%
input/app/notificationmodel.h 3 50.0%
input/app/notificationmodel.cpp 4 49.44%
Totals Coverage Status
Change from base Build 9251419383: -0.06%
Covered Lines: 7670
Relevant Lines: 12801

💛 - Coveralls

@tomasMizera
Copy link
Collaborator

Looking good, is this still WIP (work in progress) @VitorVieiraZ? :)

@VitorVieiraZ VitorVieiraZ changed the title WIP - Open sync failed dialogue when "willRetry" notification is clicked Open sync failed dialogue when "willRetry" notification is clicked May 27, 2024
@VitorVieiraZ
Copy link
Contributor Author

Looking good, is this still WIP (work in progress) @VitorVieiraZ? :)

All ready now :)

@VitorVieiraZ VitorVieiraZ changed the title Open sync failed dialogue when "willRetry" notification is clicked Open sync failed dialog when "willRetry" notification is clicked May 27, 2024
@tomasMizera tomasMizera merged commit dab887c into master May 28, 2024
12 checks passed
@tomasMizera tomasMizera deleted the fix/clickOnNotificationOpenSyncFailedDlg branch May 28, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In maintenance mode, the appr after restart doesn't show a notification about it.
3 participants