Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking service: initial prototype with fused location #3490

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wonder-sk
Copy link
Contributor

@wonder-sk wonder-sk commented Jun 3, 2024

  • service does not run in a separate process anymore
  • using FLP to get location
  • seems to track well even with screen turned off

to-do:

  • make the code more robust & finish things
  • test with various android versions
  • maybe record track to a file anyway, to prevent data loss? (commit the recorded track on app restart)
  • better android notification - regularly update tracking time and distance
  • use or don't use fused provider for tracking consistently with what positionkit uses

things to fix at some point:

  • after switching back to the app while tracking, the PositionKit's location may be old for a couple of seconds, and the tracking line may end with one long segment towards this outdated location, confusing the user. maybe we should update PositionKit's location from the latest tracked point
  • after switching back to the app after tracking for a longer time (at least a couple of minutes), the screen may stay black for a few seconds before showing things - maybe processing delayed track points?

@wonder-sk wonder-sk marked this pull request as draft June 3, 2024 08:18
Copy link

github-actions bot commented Jun 3, 2024

Pull Request Test Coverage Report for Build 10164456688

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 487 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.07%) to 59.914%

Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributepreviewcontroller.cpp 6 86.33%
input/core/coreutils.cpp 12 86.39%
input/app/appsettings.cpp 29 72.32%
input/app/activeproject.cpp 47 68.87%
input/core/merginapi.cpp 116 78.49%
input/app/inpututils.cpp 277 50.74%
Totals Coverage Status
Change from base Build 9940182064: -0.07%
Covered Lines: 7669
Relevant Lines: 12800

💛 - Coveralls

@wonder-sk wonder-sk changed the base branch from android-fused-location to master June 11, 2024 04:44
@tomasMizera
Copy link
Collaborator

tomasMizera commented Jul 30, 2024

  • Update interval -> should we keep project settings or just use a fixed one. Compare battery-efficiency on different update frequencies
  • Simulate missing Google Play (in system settings) -> Huawei phones
  • Use position provider that is selected in the app
  • Handle situation when app is killed by swiping it out while tracking is running (it keeps tracking at the moment)

@tomasMizera tomasMizera self-assigned this Jul 30, 2024
@tomasMizera tomasMizera added the FROZEN 🥶 do not merge before upcoming release label Jul 30, 2024
@tomasMizera tomasMizera added this to the 2024.4.0 milestone Jul 30, 2024
@tomasMizera tomasMizera removed the FROZEN 🥶 do not merge before upcoming release label Aug 9, 2024
@VitorVieiraZ VitorVieiraZ removed this from the 2024.4.0 milestone Aug 26, 2024
@tomasMizera tomasMizera added FROZEN 🥶 do not merge before upcoming release and removed FROZEN 🥶 do not merge before upcoming release labels Sep 26, 2024
@tomasMizera
Copy link
Collaborator

Another reason to get this sorted sooner than later: https://medium.com/@malikfarooq4321/changes-to-broadcastreceiver-in-android-14-710cb0df2133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking doesn't track when the app is in the background Support Google Play services in the Android app
4 participants