Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing picture zoom in MMPhotoPreview #3495

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Fixing picture zoom in MMPhotoPreview #3495

merged 2 commits into from
Jun 17, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Jun 5, 2024

fixingPictureZoom_.mp4

Fixes #3465

@VitorVieiraZ VitorVieiraZ reopened this Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9392575262

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 59.909%

Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9382599374: -0.06%
Covered Lines: 7669
Relevant Lines: 12801

💛 - Coveralls

2 similar comments

This comment was marked as outdated.

This comment was marked as outdated.

@tomasMizera
Copy link
Collaborator

The code looks good, let's see if we can get rid of the glitch after pinching

Copy link

Pull Request Test Coverage Report for Build 9452654945

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 59.902%

Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9382599374: -0.06%
Covered Lines: 7668
Relevant Lines: 12801

💛 - Coveralls

2 similar comments
Copy link

Pull Request Test Coverage Report for Build 9452654945

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 59.902%

Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9382599374: -0.06%
Covered Lines: 7668
Relevant Lines: 12801

💛 - Coveralls

Copy link

Pull Request Test Coverage Report for Build 9452654945

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 59.902%

Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9382599374: -0.06%
Covered Lines: 7668
Relevant Lines: 12801

💛 - Coveralls

@tomasMizera
Copy link
Collaborator

Ah, the good old PinchArea vs PinchHandler problem. Let's see if the UX is good-enough even without the DragHandler. Again, we need a minimal reproducible code here @VitorVieiraZ and report it to Qt

@tomasMizera tomasMizera added the ready-for-testing Ready to be tested by testers crew - passed review by devs label Jun 13, 2024
@VitorVieiraZ
Copy link
Contributor Author

Report for fixing occasional image jumps: https://bugreports.qt.io/browse/QTBUG-126380

@tomasMizera tomasMizera merged commit 6596849 into master Jun 17, 2024
12 checks passed
@tomasMizera tomasMizera deleted the fix/pictureZoom branch June 17, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing Ready to be tested by testers crew - passed review by devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom of the picture doesn't works well
3 participants