-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing picture zoom in MMPhotoPreview #3495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitorVieiraZ
force-pushed
the
fix/pictureZoom
branch
from
June 5, 2024 23:23
adb2bd6
to
f406dcb
Compare
Pull Request Test Coverage Report for Build 9392575262Details
💛 - Coveralls |
2 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tomasMizera
reviewed
Jun 10, 2024
The code looks good, let's see if we can get rid of the glitch after pinching |
Pull Request Test Coverage Report for Build 9452654945Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9452654945Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9452654945Details
💛 - Coveralls |
Ah, the good old PinchArea vs PinchHandler problem. Let's see if the UX is good-enough even without the |
tomasMizera
added
the
ready-for-testing
Ready to be tested by testers crew - passed review by devs
label
Jun 13, 2024
tomasMizera
approved these changes
Jun 13, 2024
Report for fixing occasional image jumps: https://bugreports.qt.io/browse/QTBUG-126380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixingPictureZoom_.mp4
Fixes #3465