Fixed issue where conversion to openapi 3 from swagger 2 definition was failing due to TypeError. #647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes one of the issue causing TypeError while converting Swagger 2.0 definition to OpenAPI 3.0. Issue was happening due to expecting certain property of definition
schemaOrRef
as string always. This results in a TypeError if this property is non-string and it can be non-string as rather than mentioning$ref
here, one can use schema directly.Fix
Fix does not affect any existing use case and only aims to avoid TypeError in certain case by checking type to be
string
before accessing string-related prototype function.