Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meros suggests LAN IPs as peers to foreign clients. #167

Open
kayabaNerve opened this issue Apr 4, 2020 · 3 comments
Open

Meros suggests LAN IPs as peers to foreign clients. #167

kayabaNerve opened this issue Apr 4, 2020 · 3 comments
Labels
untested This issue, or its fix, needs testing to verify its accuracy

Comments

@kayabaNerve
Copy link
Member

This isn't a huge bug. The foreign clients will attempt the IP, fail, and move on. That said, it isn't proper.

@kayabaNerve kayabaNerve added the bug Something isn't working label Apr 4, 2020
@kayabaNerve
Copy link
Member Author

We set the Peer.server flag in Live/Sync ManagerObj. We can unify these checks under Network, where we have access to the TransportAddress. Using the TransportAddress, we can call isLoopback/isLinkLocal and not set Peer.sever accordingly.

@kayabaNerve kayabaNerve added this to the Developer Testnet 4 Stable milestone Apr 4, 2020
@kayabaNerve
Copy link
Member Author

Actually, we can't unify this checks unless we move the handshake receiving around as well. There's a reason I didn't do that already. New plan is to pass the TransportAddress.

@kayabaNerve kayabaNerve reopened this Apr 4, 2020
@kayabaNerve kayabaNerve added untested This issue, or its fix, needs testing to verify its accuracy and removed bug Something isn't working labels Apr 4, 2020
@kayabaNerve
Copy link
Member Author

The fact Peers test now fails, as described in 7f3c23c, proves this is working. It's marked as untested until:

  • The Peers test is updated to LANPeersTest.
  • A new Peers test is built around MASQ rules (inside a Docker machine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untested This issue, or its fix, needs testing to verify its accuracy
Development

No branches or pull requests

1 participant