Move the GUI to Wry. #309
Merged
Move the GUI to Wry. #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, the script tag of Data.html isn't executing. Because of that, this is currently non-viable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #303.
Needs confirmation before #302 could be closed.
Does introduce a new issue where we allow multiple identical symbols when linking, where it's first come first serve due to using multiple Rust libraries. This isn't a deal breaker, or this wouldn't be merged, yet is a concern. I did quickly try disabling LTO for Wry; did not work. I either didn't do it properly or would need to disable it for Ristretto as well.