-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close WS Connection gracefully #6
Comments
@martbock The server now logs:
Do you think thats fine or should we digg deeper into this? Additional client logs:
|
Am I correct in assuming the PR already digs deeper into it? If not, I guess we should look into it – but we could create a separate issue and fix it later on. |
@martbock no the PR does not digg deeper yet. If you compare the log statements the output changes from an unexpected to an expected error. The question is as if this is fine or if we should handle this differently. Maybe we should discuss how to manage errors in general on thursday :) |
In order to decide if the disconnect of an client was intended or not, the intendet disconnect should be "quiet". At the moment the connection will not be closed gracefully.
If the client programm will be terminated the following output will be displayed in the server:
The text was updated successfully, but these errors were encountered: