Safe clamp from UI drag and slider #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedr
approved these changes
Jun 24, 2024
adalisk-emikhaylov
requested changes
Jun 25, 2024
source/MRViewer/MRUIStyle.ipp
Outdated
| @@ -257,6 +257,10 @@ bool slider( const char* label, T& v, const U& vMin, const U& vMax, UnitToString | |||
| ret = true; | |||
| detail::markItemEdited( ImGui::GetItemID() ); | |||
| } | |||
|
|
|||
| if ( *elemMin < *elemMax ) // sometimes ImGui does not clamp it, so make sure that value is clamped | |||
There was a problem hiding this comment.
- Please move this up to line 239 above, to prevent it from flashing incorrect value for one frame.
- I think we should also add
flags & ...AlwaysClampto the condition.
There was a problem hiding this comment.
- I think its better to clamp just before returning
- Done
adalisk-emikhaylov
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.