Issue141 2nd try #144
Merged
Issue141 2nd try #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to test a little more... but this might do it. |
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann and
andreleblanc11
|
Added some patches, and it looks like it does the right thing now. I asked the client to test. |
|
As noted by @reidsunderland we still have some multi-threading vulnerabilities... perhaps best to address. will review. |
|
The multithreading stuff is quite big... in volume... it basically means getting rid of all variables declared static as there is always a race condition when called by multiple threads. I think it's better to have a separate branch for that (maybe more than one.) and merge this stuff (already >600 loc.) as is for now. It likely solves the user's problem as-is. |
reidsunderland
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #141
Had to change global variables into pieces of context passed to library routines... a lot of changes, but that's all it did.