-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests for all Flowcb/Accept plugins #757
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into FlowCBTests
THey were broken because of the 'set_notice' header being wrong
flowcb/accept/postoverride flowcb/accept/tohttp flowcb/accept/wmotypesuffix
That item was removed as part of writing unit tests
THey were broken because of the 'set_notice' header being wrong
flowcb/accept/postoverride flowcb/accept/tohttp flowcb/accept/wmotypesuffix
That item was removed as part of writing unit tests
…into FlowCBTests
THey were broken because of the 'set_notice' header being wrong
flowcb/accept/postoverride flowcb/accept/tohttp flowcb/accept/wmotypesuffix
That item was removed as part of writing unit tests
That item was removed as part of writing unit tests
…into FlowCBTests
downloadbaseurl renamedmf tolocalfile All with 100% coverage
THey were broken because of the 'set_notice' header being wrong
flowcb/accept/postoverride flowcb/accept/tohttp flowcb/accept/wmotypesuffix
That item was removed as part of writing unit tests
That item was removed as part of writing unit tests
downloadbaseurl renamedmf tolocalfile All with 100% coverage
…into FlowCBTests
Should have been part of the inital set of fixes, but they weren't known until the tests were fixed.. sort of circular problem.
There's a class we're testing that starts with 'Test', and it was throwing warnings for pytest. Updating the config to only look for classes that start with 'Test_*' now.
These fixes reflect the changes that were done in #756 Some of them also are fixes to make sure these tests are successful when run as part of the whole suite (caplog message counts among them). Those assertions probably aren't all that purposeful, and checking that the desired logs are in the list is better, but here we are..
they will not affect the integration tests, so it should be fine to fix any lingering issues post-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a full test suite for all 23 FlowCB Accept plugins.
Test_
are treated as test classes (default is justTest
)Notable innovations with these tests
wmotypesuffix_test.py
time
, andrandom
, but also one withurllib
config
, andmessage
), in order to properly build testsThere's also a couple of late fixes to the actual plugins here, which are required to make them operate as designed