Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

758 adding wiskis query support #759

Merged
merged 13 commits into from
Sep 29, 2023
Merged

758 adding wiskis query support #759

merged 13 commits into from
Sep 29, 2023

Conversation

petersilva
Copy link
Contributor

as per #758 , add a proof of concept WISKI web services polling thing, supporting the token management needed by Ontario Power Generation.

  • Generates tokens, supplies them to kiwis_pie (python wrapper module to access WISKI)
  • polls the server given by pollUrl
  • writes timeseries to a local directory given by directory
  • generates posts using provided baseUrl etc... as per normal post/poll.
  • implemented as a flowcb/scheduled plugin.
  • example configuration file provided.
  • for testing, can be invoked on command line.
  • works on linux and/or windows (different file naming conventions due restrictions on windows.)

generic items:

  • noticed a bug in scheduled_intervals (applies to most of the ones deployed) fixed.
  • found a bug in scheduled/init as well (missing argument would be found by derived classes.)
  • documented use of None (as opposed to NONE) for filename setting... needed when filenames have colons in them.

petersilva and others added 13 commits September 19, 2023 20:02
@petersilva
found missing argument to init in flowcb/scheduled. #758
516fbc6
@petersilva
bug with scheduled_intervals. #758
dce6603
@petersilva
initial working wiski plugin as part of #758
2d3e0ef
@petersilva
making scheduling easier for debug/testing.
624e210
@petersilva
porting wiski.py to run on windows also
77c2f5a
@petersilva
so... original token request code does not seem to work, the example
8552207 
from OPG creates an "Error" token and then uses it without signalling
any error.  this was copied... so when it failed, it signalled nothing.

Adding error message for when token request fails.
also the kiwis_pie library wasn't being given the token, to the
authentication failure had no effect... we are effectively only doing
unauthenticated request.

kiwis_pie doesn't support bearer tokens, so forked that preparing a
patch for that, but can't confirm it works until I get a working token.
token submission currently returning an error.
@petersilva
token authorization fixed. Getting correct tokens now.
0f97f89
@petersilva
use self.main_url for some calls that had hard-coded URLs before.
a654331 
unfortunately get_timeseries_list returning empty for now... work in
progress.
@petersilva
ok, now just getting all timeseries per station, then dumping each one.
7b0bf99 
that gets us some data.
@petersilva
adding sample config, adding finer-grained honouring of stop requests.
011ffc0
@petersilva
generate filenames with colons in them without Sundew getting in the
4fad595 
way.
@petersilva
adding support for features mechanism for wiski.
efdc2aa
@petersilva
a little more intro text.
304bfa8
@petersilva
Copy link
Contributor Author

Oh yeah, and it turns out that github has it´s own naming scheme for issue branches, so I used that one this time. There is a create a banch for this issue button on the right, and it uses this scheme... comments welcome.

tysonkaufmann
tysonkaufmann approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@tysonkaufmann tysonkaufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tysonkaufmann tysonkaufmann merged commit 4f0e929 into v03_wip Sep 29, 2023
21 of 23 checks passed
@petersilva petersilva deleted the 758-adding-wiskis-query-support branch October 22, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tysonkaufmann tysonkaufmann tysonkaufmann approved these changes

@reidsunderland reidsunderland Awaiting requested review from reidsunderland

@MagikEh MagikEh Awaiting requested review from MagikEh

@andreleblanc11 andreleblanc11 Awaiting requested review from andreleblanc11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petersilva @tysonkaufmann