[MyMeta] Use Magic: The Gathering's Five Colored Disposition Matrix #384
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/metafam/the-game/BibvpcL3QMAhi3Lcan1ZLbWLQXyY [Deployment for 59127fe failed] |
| @@ -25,7 +25,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@chakra-ui/icons": "1.0.3", | |||
| "@chakra-ui/react": "1.1.5", | |||
| "@chakra-ui/react": "^1.3.3", | |||
There was a problem hiding this comment.
I was getting an error about an object assignment function that I could only resolve by upgrading Chakra.
| @@ -56,7 +56,7 @@ export const LoginButton: React.FC = () => { | |||
| fontWeight="normal" | |||
| title={hasEditedProfile ? 'Edit profile' : 'Setup profile'} | |||
| > | |||
| <SettingsIcon w={7} h={7} color="cyan.400"/> | |||
| <SettingsIcon h='1.25rem' w='1.25rem' color="cyan.400"/> | |||
There was a problem hiding this comment.
For whatever reason, these were displaying as 7px⨯7px. Why, I don't know, but this was the simplest solution.
| @@ -282,7 +284,7 @@ export const PageHeader: React.FC = () => { | |||
| WebkitBackdropFilter: 'blur(10px)', | |||
| }} | |||
| /> | |||
| {/* ToDo: switch to BoxedNextImage */} | |||
There was a problem hiding this comment.
This is the bottom of the app drawer and it is surprisingly difficult to style, particularly when combined with Next.js's Image class. It is not worth the time to get this to work.
| {getPlayerDescription(player).length > BIO_LENGTH && ( | ||
| {show | ||
| ? description | ||
| : `${description.substring(0, MAX_BIO_LENGTH - 9)}…` |
There was a problem hiding this comment.
The - 9 is to remove characters to be replaced with "Read more". Otherwise, my blurb of 243 characters is longer when shortened than it would be otherwise.
| @@ -50,7 +51,7 @@ export const SetupTimeZone: React.FC<SetupTimezoneProps> = ({timeZone, setTimeZo | |||
|
|
|||
| return ( | |||
| <FlexContainer> | |||
| <MetaHeading mb={10} mt={-64} textAlign="center"> | |||
There was a problem hiding this comment.
This pushed the header off the top of the screen in mobile.
dysbulic
added
ready-for-review
|
After discussing the design with @peth-yursick, I made a variety of changes. These were based off the @mymeta/profile-edit-nav branch, and it is now the place to look for the most up to data code. So, I'm closing this request… |
This changeset addresses #312 which requests the removal of the Enneagram for personality typing to be replaced with Magic's five color dispositions.
The design renames the basic colors to descriptive adjectives. To break from the extensive canon of writing on the MTG system is an arguable decision, but it is further complicated by the fact that one of the existing MTG combinations (red/black/blue/green) has the same name, "Chaos", as is used in the MetaGame renaming scheme for Red.
Also, the original design was a two-phase configuration. First the user selected the colors they wanted from the base set of five, then they adjust the ratios of those colors by sliding the borders between a set of percentages.
The thing is that it is the choice of which colors from the base set is what determines disposition in the MTG scheme. Additional adjustment beyond their selection is unnecessary, and opens the possibility of reducing colors to zero or other pathological cases.
This implementation represents all the colors in a set as equal in proportion. The combinations are referenced according to their MTG designation, and there's a link to an as of yet incomplete site which will give an overview of each combination.