allow a player to store their pronouns as part of their profile #711

socksrust · 2021-07-16T20:14:20Z

Adds pronouns as a profile characteristic.

vercel · 2021-07-16T20:14:23Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/metafam/the-game/Ap5VQqU1Zfxp5vmqypjVS8CvaSrd
✅ Preview: Failed

[Deployment for 15c58c5 failed]

dan13ram · 2021-07-17T10:33:02Z

@jaburx Thank you so much for working on this.

Could you take a look at the build issues ? Seems like typecheck is failing.

Also would be super great if you split this PR into two where the first one includes only backend changes, and while the second one include only frontend changes.

This would greatly help in the code review & merge process, and also that way the frontend only PR can have a working preview deployment to test with :)

Cheers!

dysbulic · 2021-07-22T06:49:07Z

packages/web/components/Setup/SetupDone.tsx

@@ -7,7 +7,7 @@ import React, { useState } from 'react';

 export const SetupDone: React.FC = () => {
  const router = useRouter();
-  const { user } = useUser({ redirectTo: '/' });


¿Could you describe why you removed this?

I always thought it was a little semantically stilted, but didn't change it b/c of not wanting to introduce side effects I was unaware of.

Maybe to guarantee a continuance of behavior you could set a default value in the useUser definition of redirectTo = '/'.

this was causing the buggy behaviour when visiting one of the profile setup pages and the user would just get redirected to /players, i fixed it in packages/web/lib/hooks/index.ts by renaming the redirectIfFound into redirectIfNotFound and setting to false by default and tweaking some of its behaviour. Now everything works the same, apart from the bug in player setup pages, which is gone.

packages/web/components/Setup/SetupPronouns.tsx

packages/web/components/Player/Section/PlayerPronouns.tsx

packages/web/components/Player/Section/PlayerHero.tsx

packages/web/components/Setup/SetupPronouns.tsx

packages/web/graphql/mutations/player.ts

dysbulic · 2021-08-05T06:55:47Z

¿@jaburx, have you abandoned this code? You're pretty close. If you respond to a couple of my comments, I'll merge this.

Udit-takkar · 2021-09-09T19:02:31Z

Is this issue still open? Can i look into this? @dysbulic

dysbulic · 2021-10-27T14:47:00Z

Closing to trigger the Google Cloud builds.

github-actions · 2021-10-27T15:29:30Z

Successfully deployed a Preview of this Pull Request
Frontend
Hasura

dysbulic · 2021-10-27T15:37:17Z

So, @vidvidvid, the Google deployments are successful, so everything’s good. I'll review it shortly.

vidvidvid · 2021-10-27T16:22:01Z

nicu 👍

dysbulic · 2021-10-31T03:37:58Z

This code is based on a version of the profile editing page that doesn't exist anymore. This is in part a result of the time it took to complete the review, which is largely because I was unaware the issues I had raised had been resolved.

I've been trying to figure out how to remove Dependabot from my GitHub activity feed. I turned off notifications in the settings, but I keep getting them. They make it harder to distinguish important updates.

Also, however, the redesign of the profile pages has been ongoing for a almost a month now, so this issue shouldn't be a surprise to anyone.

To me, the correct next step is to put in a request to the design guild for a profile page with pronouns in it. ¿Right, @davort?

vidvidvid · 2021-10-31T07:31:03Z

Hey, the setup wizard steps still exist. They are just accessible only the first time the user logs in and sets up their profile.
Or are you talking about some other non-existent profile editing page?

vidvidvid · 2021-10-31T07:43:23Z

@dysbulic i'm gonna merge the develop branch into it and fix the conflicting files, ok?

vidvidvid · 2021-10-31T07:44:35Z

actually, i would also need to add the pronouns input field to the new profile edit dialog, but this can be done after this pr is merged, so we don't keep bloating it up. what do you think?

vidvidvid · 2021-10-31T08:18:20Z

For some reason the build appears to fail, but when I run yarn backend:build locally, it builds it without any errors: @metafam/backend: [07:47:08] Generate outputs [failed] is failing it.
I will try to re-run the checks.

github-actions · 2021-11-02T14:51:24Z

Successfully deployed a Preview of this Pull Request
Frontend
Hasura

dysbulic · 2021-11-02T15:28:25Z

@vidvidvid, just one last quibble. On the roles page which precedes pronouns, the submit button is entitled "Professional Profile" rather than "Pronouns".

Also, on the roles page, could you switch whiteSpace from nowrap to auto for the "Make Primary / Secondary" and "Remove Role" buttons when selecting a role? They are overdrawing each other.

dysbulic

Overall looks good. I had some syntactic suggestions, but the only real blocking issue is the text of the submit button on the preceding page.

packages/web/components/Setup/SetupPronouns.tsx

alalonde · 2021-11-02T17:29:42Z

Two requests, now that the edit profile branch is in here:

only show pronouns section of the player card if there is data set
add pronoun input field to the edit modal

davort · 2021-11-02T18:24:22Z

Overall looks good. I had some syntactic suggestions, but the only real blocking issue is the text of the submit button on the preceding page.

I don't think pronouns as a separate/standalone step in the onboarding flow is optimal.

In principle, we'd want to keep the whole flow as fluid as possible. That said, perhaps we ought to consider "bundling" the choice of pronouns with some other, simpler choices, such as "Display name" or "Website"?

vidvidvid · 2021-11-02T22:10:59Z

WIll take care of @dysbulic 's and @alalonde 's suggestions tomorrow, gonna sleep now. @davort I think your suggestion makes sense and it would be nice to bundle up some of the choices, but I'd prefer to get done with this pr and make another issue for a slight re-work of the setup wizard - that way 1. you get time to make a plan on what to put together and 2. we can finally close this pr that's been open for months, what do you think?

davort · 2021-11-03T05:21:48Z

WIll take care of @dysbulic 's and @alalonde 's suggestions tomorrow, gonna sleep now. @davort I think your suggestion makes sense and it would be nice to bundle up some of the choices, but I'd prefer to get done with this pr and make another issue for a slight re-work of the setup wizard - that way 1. you get time to make a plan on what to put together and 2. we can finally close this pr that's been open for months, what do you think?

Thanks @vidvidvid - sounds good to me. Let's do like you suggested 👍

vidvidvid · 2021-11-03T11:47:23Z

Fixed @dysbulic 's suggestions, also slightly improved the buttons from the screenshot you provided:

Also took care of @alalonde 's requests:

if pronouns weren't selected, hide the section
added pronoun input field to the edit modal

We can eventually make a follow up with re-organisation of the setup wizard steps.

alalonde · 2021-11-05T04:55:30Z

I don't think pronouns as a separate/standalone step in the onboarding flow is optimal.

I would go even farther and say that it shouldn't be in the onboarding flow at all. There are probably too many steps already; really only the most critical information should be required during onboarding. And I suspect that the people that really feel strongly about inputting their pronoun preferences will easy find the field in the edit profile modal.

github-actions · 2021-11-05T05:01:22Z

Successfully undeployed the Preview of this Pull Request

socksrust linked an issue Jul 16, 2021 that may be closed by this pull request

[MyMeta] Allow a Player to store their pronouns as part of their profile #331

Closed

dysbulic requested changes Jul 22, 2021

View reviewed changes

dysbulic mentioned this pull request Aug 18, 2021

[MyMeta] Allow a Player to store their pronouns as part of their profile #331

Closed

vercel bot had a problem deploying to Preview October 7, 2021 15:43 Failure

vercel bot had a problem deploying to Preview October 7, 2021 16:42 Failure

vidvidvid force-pushed the feat/pronous-profile branch from 6be80eb to f2552ab Compare October 7, 2021 16:43

vercel bot had a problem deploying to Preview October 7, 2021 16:52 Failure

vercel bot had a problem deploying to Preview October 7, 2021 17:44 Failure

vercel bot had a problem deploying to Preview October 7, 2021 19:04 Failure

vidvidvid force-pushed the feat/pronous-profile branch from c0a8b88 to b5601fe Compare October 7, 2021 19:53

vercel bot had a problem deploying to Preview October 7, 2021 19:53 Failure

vidvidvid requested a review from dysbulic October 7, 2021 19:55

vercel bot had a problem deploying to Preview October 7, 2021 20:06 Failure

vidvidvid mentioned this pull request Oct 16, 2021

Edit profile and profile page update #864

Merged

10 tasks

dysbulic closed this Oct 27, 2021

dysbulic reopened this Oct 27, 2021

vercel bot had a problem deploying to Preview October 31, 2021 07:46 Failure

dysbulic requested changes Nov 2, 2021

View reviewed changes

packages/web/components/Setup/SetupPronouns.tsx Outdated Show resolved Hide resolved

packages/web/components/Setup/SetupPronouns.tsx Show resolved Hide resolved

socksrust and others added 13 commits November 3, 2021 12:29

allow a player to store their pronouns as part of their profile

b0ac271

allow a player to store their pronouns as part of their profile

11cb85d

fix the pr + fix the useUser redirect bug

f434bf2

fix pronouns type

937cbf8

really fix pronouns type

32ffaed

fix remaining issues

8ea2365

get rid of react warning

9a00a69

fix: rebasing/merging problem

ffd695e

fix: revert formatting changes

b4ba5af

fix: order of steps

c3ffff0

fix: capitalisation and disabling button when no user

61a3183

fix: style roles buttons

813891e

feat: add pronouns input to edit form

15c58c5

vidvidvid force-pushed the feat/pronous-profile branch from 245edca to 15c58c5 Compare November 3, 2021 11:46

vercel bot had a problem deploying to Preview November 3, 2021 11:46 Failure

vidvidvid requested review from dysbulic and alalonde November 3, 2021 11:47

alalonde approved these changes Nov 5, 2021

View reviewed changes

alalonde merged commit d164de0 into develop Nov 5, 2021

alalonde deleted the feat/pronous-profile branch November 5, 2021 04:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow a player to store their pronouns as part of their profile #711

allow a player to store their pronouns as part of their profile #711

socksrust commented Jul 16, 2021 •

edited by dysbulic

Loading

vercel bot commented Jul 16, 2021 •

edited

Loading

dan13ram commented Jul 17, 2021 •

edited

Loading

dysbulic Jul 22, 2021

vidvidvid Oct 7, 2021

dysbulic commented Aug 5, 2021

Udit-takkar commented Sep 9, 2021 •

edited

Loading

dysbulic commented Oct 27, 2021

github-actions bot commented Oct 27, 2021

dysbulic commented Oct 27, 2021

vidvidvid commented Oct 27, 2021

dysbulic commented Oct 31, 2021

vidvidvid commented Oct 31, 2021

vidvidvid commented Oct 31, 2021

vidvidvid commented Oct 31, 2021

vidvidvid commented Oct 31, 2021

github-actions bot commented Nov 2, 2021

dysbulic commented Nov 2, 2021

dysbulic left a comment

alalonde commented Nov 2, 2021

davort commented Nov 2, 2021

vidvidvid commented Nov 2, 2021

davort commented Nov 3, 2021

vidvidvid commented Nov 3, 2021 •

edited

Loading

alalonde commented Nov 5, 2021 •

edited

Loading

github-actions bot commented Nov 5, 2021

allow a player to store their pronouns as part of their profile #711

allow a player to store their pronouns as part of their profile #711

Conversation

socksrust commented Jul 16, 2021 • edited by dysbulic Loading

vercel bot commented Jul 16, 2021 • edited Loading

dan13ram commented Jul 17, 2021 • edited Loading

dysbulic Jul 22, 2021

Choose a reason for hiding this comment

vidvidvid Oct 7, 2021

Choose a reason for hiding this comment

dysbulic commented Aug 5, 2021

Udit-takkar commented Sep 9, 2021 • edited Loading

dysbulic commented Oct 27, 2021

github-actions bot commented Oct 27, 2021

dysbulic commented Oct 27, 2021

vidvidvid commented Oct 27, 2021

dysbulic commented Oct 31, 2021

vidvidvid commented Oct 31, 2021

vidvidvid commented Oct 31, 2021

vidvidvid commented Oct 31, 2021

vidvidvid commented Oct 31, 2021

github-actions bot commented Nov 2, 2021

dysbulic commented Nov 2, 2021

dysbulic left a comment

Choose a reason for hiding this comment

alalonde commented Nov 2, 2021

davort commented Nov 2, 2021

vidvidvid commented Nov 2, 2021

davort commented Nov 3, 2021

vidvidvid commented Nov 3, 2021 • edited Loading

alalonde commented Nov 5, 2021 • edited Loading

github-actions bot commented Nov 5, 2021

socksrust commented Jul 16, 2021 •

edited by dysbulic

Loading

vercel bot commented Jul 16, 2021 •

edited

Loading

dan13ram commented Jul 17, 2021 •

edited

Loading

Udit-takkar commented Sep 9, 2021 •

edited

Loading

vidvidvid commented Nov 3, 2021 •

edited

Loading

alalonde commented Nov 5, 2021 •

edited

Loading