fix!(keyring-eth-ledger-bridge): change addAccounts to return new accounts only
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesposito
commented
Sep 27, 2024
There was a problem hiding this comment.
Tests were passing regardless of the issue so even if we are not adding any new test case, they have been changed to also cover this behavior
danroc
approved these changes
Sep 27, 2024
mikesposito
changed the title
addAccounts returns new accounts onlyaddAccounts returns new accounts only
mikesposito
changed the title
addAccounts returns new accounts onlyaddAccounts returns new accounts only
ccharly
changed the title
addAccounts returns new accounts onlyaddAccounts return new accounts only
ccharly
changed the title
addAccounts return new accounts onlyaddAccounts to return new accounts only
ccharly
changed the title
addAccounts to return new accounts onlyaddAccounts to return new accounts only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
addAccountsmethod should return newly create accounts, instead of all the accounts present in the keyring.Related: https://github.com/MetaMask/accounts-planning/issues/615
Examples