Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Mainnet NFT Autodetect API #536

Merged
merged 9 commits into from
Jul 27, 2021
Merged

Bug: Mainnet NFT Autodetect API #536

merged 9 commits into from
Jul 27, 2021

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Jul 22, 2021

OpenSea changed the maximum limit allowed for the GET asset request from 300 to 50.

  • Added the functionality to fetch 50 assets at a time until all of the user's assets have been fetched

@sethkfman sethkfman requested a review from a team as a code owner July 22, 2021 21:45
@wachunei wachunei mentioned this pull request Jul 26, 2021
api,
openSeaApiKey ? { headers: { 'X-API-KEY': openSeaApiKey } } : {},
15000,
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sethkfman Does the API no longer allow requests without an API key? Was that else block never really used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adonesky1 It looks like it is still optional. Per the OpenSea Documentation:

X-API-KEY (string)
Your optional API Key (contact us to request one!)

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I didn't test this but the code looks good!

@sethkfman sethkfman merged commit 39fbbe9 into main Jul 27, 2021
@sethkfman sethkfman deleted the bugfix/nft-autodetect branch July 27, 2021 16:03
@adonesky1 adonesky1 mentioned this pull request Jul 27, 2021
rickycodes added a commit that referenced this pull request Aug 3, 2021
…to dynamic-speed-up

* 'dynamic-speed-up' of github.com:MetaMask/controllers:
  Bump @metamask/auto-changelog from 2.4.0 to 2.5.0 (#549)
  Update Changelog (#548)
  14.0.2 (#547)
  Fix `resetPolling` functionality (#546)
  TokenService improvements (#541)
  Release/14.0.1 (#545)
  Make gweiDecToWEIBN util resilient against params with too many decimals (#544)
  Bump @metamask/contract-metadata from 1.27.0 to 1.28.0 (#540)
  14.0.0 (#539)
  Bug: Mainnet NFT Autodetect API  (#536)
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* updated api maximum for collectibles fetch

* consolidated if statement

* updated mock test data

* added logic to fetch all users collectables
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* updated api maximum for collectibles fetch

* consolidated if statement

* updated mock test data

* added logic to fetch all users collectables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants