-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Mainnet NFT Autodetect API #536
Conversation
api, | ||
openSeaApiKey ? { headers: { 'X-API-KEY': openSeaApiKey } } : {}, | ||
15000, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sethkfman Does the API no longer allow requests without an API key? Was that else block never really used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adonesky1 It looks like it is still optional. Per the OpenSea Documentation:
X-API-KEY (string)
Your optional API Key (contact us to request one!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I didn't test this but the code looks good!
…to dynamic-speed-up * 'dynamic-speed-up' of github.com:MetaMask/controllers: Bump @metamask/auto-changelog from 2.4.0 to 2.5.0 (#549) Update Changelog (#548) 14.0.2 (#547) Fix `resetPolling` functionality (#546) TokenService improvements (#541) Release/14.0.1 (#545) Make gweiDecToWEIBN util resilient against params with too many decimals (#544) Bump @metamask/contract-metadata from 1.27.0 to 1.28.0 (#540) 14.0.0 (#539) Bug: Mainnet NFT Autodetect API (#536)
* updated api maximum for collectibles fetch * consolidated if statement * updated mock test data * added logic to fetch all users collectables
* updated api maximum for collectibles fetch * consolidated if statement * updated mock test data * added logic to fetch all users collectables
OpenSea changed the maximum limit allowed for the GET asset request from 300 to 50.