feat: native scrypt support on Profile Sync Controller #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/profile-sync-controller/src/controllers/user-storage/encryption/cache.ts
Outdated
Show resolved
Hide resolved
packages/profile-sync-controller/src/controllers/user-storage/encryption/cache.ts
Outdated
Show resolved
Hide resolved
packages/profile-sync-controller/src/controllers/user-storage/encryption/encryption.ts
Show resolved
Hide resolved
legobeat
reviewed
Sep 6, 2024
packages/profile-sync-controller/src/controllers/user-storage/encryption/encryption.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.test.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/controllers/user-storage/services.ts
Show resolved
Hide resolved
Prithpal-Sooriya
force-pushed
the
tmp/native-scrypt
branch
from
688f84e
to
d3d0fda
Compare
Prithpal-Sooriya
approved these changes
Sep 6, 2024
Prithpal-Sooriya
changed the title
Prithpal-Sooriya
added
the
team-notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR implements a pattern of using a React Native scrypt to encryption while dealing with React native client. This was necessary due the poor performance for mobile devices relying on the node implementation. This improves the performance for mobile clientes in a order of 20x.
References
Changelog
@metamask/profile-sync-controllerNativeScrypttoUserStorageControllerEncryptionto use eitherNativeScyptor default to the original@noble-hashes/scrypt-asyncChecklist