Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NOTIFY-1079): various account syncing improvements #4675

Merged
merged 5 commits into from
Sep 10, 2024
Merged

feat(NOTIFY-1079): various account syncing improvements #4675

merged 5 commits into from
Sep 10, 2024

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Sep 10, 2024 •
edited
Loading

Explanation

This PR:

  • removes the big sync throttling
  • prevents AccountsController events to fire an upwards sync during the big sync

References

NOTIFY-1079

Changelog

@metamask/profile-sync-controller

  • REMOVED: Account sync throttling
  • ADDED: Prevent AccountsController events from firing during account sync "big sync"

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@mathieuartu mathieuartu marked this pull request as ready for review September 10, 2024 10:35
@mathieuartu mathieuartu requested a review from a team as a code owner September 10, 2024 10:35
@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Sep 10, 2024
@mathieuartu mathieuartu merged commit 7c4b57d into main Sep 10, 2024
116 checks passed
@mathieuartu mathieuartu deleted the feat/various_account_syncing_improvements branch September 10, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legobeat legobeat legobeat left review comments

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

Assignees
No one assigned
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathieuartu @Prithpal-Sooriya @legobeat