[CHANGED] - Testnet Ticker format update <network name>ETH #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rollers into improvement/testnet-ticker
…rollers into improvement/testnet-ticker
…rollers into improvement/testnet-ticker
sethkfman
changed the title
mcmire
approved these changes
Jul 7, 2022
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* added logic to update testnet ticker symbol * added mainet ticker test * added dist folder * PR feedback added NetworkType constant and applied to NetworkController * fixed lint warning * removed dist folder and update .gitignore
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* added logic to update testnet ticker symbol * added mainet ticker test * added dist folder * PR feedback added NetworkType constant and applied to NetworkController * fixed lint warning * removed dist folder and update .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Description
This work was done to support the application layers displaying test network ETH. The extension application performed this work in the app layer because they don't yet support the controllers where this is added. Once, the extension uses the network controllers then they will be in parity.
References
Technical Changes
Added Testnet Object Type
Changed getTicker function to return prefixed ETH ticker
Added test case
Confirmed removal of dist updates
CHANGED:
Checklist