Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: switch token pricing to CoinGecko API #92

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Conversation

bitpshr
Copy link
Contributor

@bitpshr bitpshr commented Apr 9, 2019

This pull request updates the TokenRatesController to use the CoinGecko API instead of the Balanc3 API that will be shut down in the near future. The API seemed to hold up under the local stress tests I did (50+ tokens per request at 100 requests per minute - the rate limit max - for several minutes).

Resolves #83

Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bitpshr bitpshr merged commit 9c83045 into master Apr 10, 2019
@bitpshr bitpshr deleted the feature/coingecko branch April 10, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants