Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README update file location paths for default branch rename main #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

README update file location paths for default branch rename main #118

wants to merge 1 commit into from

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Mar 31, 2022 •
edited
Loading

Updates for switching from master to main as default branch.

@sethkfman sethkfman requested a review from a team as a code owner March 31, 2022 17:32
Fatxx
Fatxx approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owencraston
Copy link
Contributor

Both of these links return a 404 for me
Screen Shot 2022-03-31 at 2 57 04 PM

legobeat
legobeat suggested changes May 1, 2023
View reviewed changes
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch is missing and master is still the default branch of this repo.

@legobeat
Copy link
Contributor

legobeat commented May 1, 2023

Also see MetaMask/eth-phishing-detect#12210 for example of how to keep legacy master automatically up to date with new base main post-switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legobeat legobeat legobeat requested changes

@Fatxx Fatxx Fatxx approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sethkfman @owencraston @legobeat @Fatxx