Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Heading-SM-Regular by Body-LG-Medium #194

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Conversation

SaraCheikh
Copy link
Contributor

@SaraCheikh SaraCheikh commented Jul 13, 2022

Updating typography tokens

Screenshots

Screen Shot 2022-07-27 at 3 45 32 PM

Screen Shot 2022-07-27 at 3 46 34 PM

@SaraCheikh SaraCheikh requested a review from a team as a code owner July 13, 2022 15:42
@metamaskbot
Copy link
Collaborator

Builds ready [86c8e7e]

@metamaskbot
Copy link
Collaborator

Builds ready [7ed6902]

@georgewrmarshall georgewrmarshall self-assigned this Jul 21, 2022
@georgewrmarshall
Copy link
Collaborator

Going to update this PR to only add the new Typography style. Removing the old one would be considered a breaking change

@georgewrmarshall georgewrmarshall added the code Issue related to code work label Jul 22, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [3430244]

@metamaskbot
Copy link
Collaborator

Builds ready [262f7e6]

@metamaskbot
Copy link
Collaborator

Builds ready [3662686]

@garrettbear garrettbear merged commit a1caf50 into main Aug 4, 2022
@garrettbear garrettbear deleted the updating-bodytype branch August 4, 2022 20:28
garrettbear added a commit that referenced this pull request Aug 4, 2022
Replaced Heading-SM-Regular by Body-LG-Medium (#194)

* Replaced Heading-SM-Regular by Body-LG-Medium

* Replaced Heading-SM-Regular by Body-LG-Medium

* Adding BodyLGMedium to small screen and large screen

* Adding deprecated tags

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

DS210: Update large body text line height
garrettbear added a commit that referenced this pull request Aug 8, 2022
Replaced Heading-SM-Regular by Body-LG-Medium (#194)

* Replaced Heading-SM-Regular by Body-LG-Medium

* Replaced Heading-SM-Regular by Body-LG-Medium

* Adding BodyLGMedium to small screen and large screen

* Adding deprecated tags

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

DS210: Update large body text line height

DS-210: update font tokens, css based typeography stories, fix mobile sDisplayMD

DS-210: fix display font test

DS-210: use sans font token

Replaced Heading-SM-Regular by Body-LG-Medium (#194)

* Replaced Heading-SM-Regular by Body-LG-Medium

* Replaced Heading-SM-Regular by Body-LG-Medium

* Adding BodyLGMedium to small screen and large screen

* Adding deprecated tags

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

DS-210: Large screen font story fix

DS-210: trim story string
garrettbear added a commit that referenced this pull request Aug 8, 2022
Replaced Heading-SM-Regular by Body-LG-Medium (#194)

* Replaced Heading-SM-Regular by Body-LG-Medium

* Replaced Heading-SM-Regular by Body-LG-Medium

* Adding BodyLGMedium to small screen and large screen

* Adding deprecated tags

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

DS210: Update large body text line height

DS-210: update font tokens, css based typeography stories, fix mobile sDisplayMD

DS-210: fix display font test

DS-210: use sans font token

Replaced Heading-SM-Regular by Body-LG-Medium (#194)

* Replaced Heading-SM-Regular by Body-LG-Medium

* Replaced Heading-SM-Regular by Body-LG-Medium

* Adding BodyLGMedium to small screen and large screen

* Adding deprecated tags

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

DS-210: Large screen font story fix

DS-210: trim story string

DS-210: rebase fix
garrettbear added a commit that referenced this pull request Aug 8, 2022
Replaced Heading-SM-Regular by Body-LG-Medium (#194)

* Replaced Heading-SM-Regular by Body-LG-Medium

* Replaced Heading-SM-Regular by Body-LG-Medium

* Adding BodyLGMedium to small screen and large screen

* Adding deprecated tags

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

DS210: Update large body text line height

DS-210: update font tokens, css based typeography stories, fix mobile sDisplayMD

DS-210: fix display font test

DS-210: use sans font token

Replaced Heading-SM-Regular by Body-LG-Medium (#194)

* Replaced Heading-SM-Regular by Body-LG-Medium

* Replaced Heading-SM-Regular by Body-LG-Medium

* Adding BodyLGMedium to small screen and large screen

* Adding deprecated tags

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

DS-210: Large screen font story fix
garrettbear added a commit that referenced this pull request Aug 8, 2022
Replaced Heading-SM-Regular by Body-LG-Medium (#194)

* Replaced Heading-SM-Regular by Body-LG-Medium

* Replaced Heading-SM-Regular by Body-LG-Medium

* Adding BodyLGMedium to small screen and large screen

* Adding deprecated tags

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

DS210: Update large body text line height

DS-210: update font tokens, css based typeography stories, fix mobile sDisplayMD

DS-210: fix display font test

DS-210: use sans font token

Replaced Heading-SM-Regular by Body-LG-Medium (#194)

* Replaced Heading-SM-Regular by Body-LG-Medium

* Replaced Heading-SM-Regular by Body-LG-Medium

* Adding BodyLGMedium to small screen and large screen

* Adding deprecated tags

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

DS-210: Large screen font story fix

DS-210: fix small display md font weight

DS210: fix deprecated tags
georgewrmarshall pushed a commit that referenced this pull request Aug 9, 2022
Replaced Heading-SM-Regular by Body-LG-Medium (#194)

* Replaced Heading-SM-Regular by Body-LG-Medium

* Replaced Heading-SM-Regular by Body-LG-Medium

* Adding BodyLGMedium to small screen and large screen

* Adding deprecated tags

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

DS210: Update large body text line height

DS-210: update font tokens, css based typeography stories, fix mobile sDisplayMD

DS-210: fix display font test

DS-210: use sans font token

Replaced Heading-SM-Regular by Body-LG-Medium (#194)

* Replaced Heading-SM-Regular by Body-LG-Medium

* Replaced Heading-SM-Regular by Body-LG-Medium

* Adding BodyLGMedium to small screen and large screen

* Adding deprecated tags

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

DS-210: Large screen font story fix

DS-210: fix small display md font weight

DS210: fix deprecated tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Issue related to code work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants