Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build and aligns with module template #667

Merged
merged 11 commits into from
Apr 25, 2024
Merged

Conversation

georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented Apr 25, 2024

Description

This PR aims to realign the design tokens codebase with the latest standards and updates from the MetaMask module template. Utilizing the template-sync tool, we will incorporate changes and improvements from recent commits to the MetaMask module template into our design tokens repository.

Commits from module template included:

Related issues

Fixes: N/A

Manual testing steps

  1. Review the changes introduced from the MetaMask module template commits to ensure they are correctly integrated into the design tokens codebase.
  2. Verify updates made to the README look good

Screenshots/Recordings

Before

N/A - This PR focuses on codebase alignment and process improvements rather than visual UI changes.

After

N/A - This PR focuses on codebase alignment and process improvements rather than visual UI changes.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues.
  • I've included manual testing steps.
  • I’ve included screenshots/recordings if applicable.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR.
  • I’ve properly set the pull request status to "ready for review".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system label Apr 25, 2024
@georgewrmarshall georgewrmarshall self-assigned this Apr 25, 2024
Copy link

socket-security bot commented Apr 25, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@yarnpkg/types@4.0.0 None 0 8.8 kB yarnbot

View full report↗︎

Copy link

socket-security bot commented Apr 25, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@georgewrmarshall
Copy link
Collaborator Author

@SocketSecurity ignore all

@metamaskbot
Copy link
Collaborator

Builds ready [19000f6]

Storybook: Storybook

@georgewrmarshall georgewrmarshall marked this pull request as ready for review April 25, 2024 21:08
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner April 25, 2024 21:08
@georgewrmarshall georgewrmarshall changed the title Fix/template sync fix: fixes build and aligns with module template Apr 25, 2024
@georgewrmarshall georgewrmarshall changed the title fix: fixes build and aligns with module template fix: build and aligns with module template Apr 25, 2024
@georgewrmarshall georgewrmarshall merged commit 71f48fa into main Apr 25, 2024
19 checks passed
@georgewrmarshall georgewrmarshall deleted the fix/template-sync branch April 25, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-design-system All issues relating to design system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants