Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrading storybook to 8.1.2 #690

Merged
merged 2 commits into from
May 21, 2024
Merged

chore: upgrading storybook to 8.1.2 #690

merged 2 commits into from
May 21, 2024

Conversation

georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented May 17, 2024

Description

This PR upgrades Storybook from version 8.0.9 to 8.1.2 The upgrade includes some minor updates the storybook configuration files main.ts and preview.ts. The motivation for this upgrade is to utilize the latest enhancements and keep up to date with our developer tooling technologies.

Migration docs: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#from-version-80x-to-81x

Related issues

Fixes: N/A

Manual testing steps

  1. Go to the storybook build of this PR or pull this branch and run yarn && yarn storybook
  2. Check all documentation and stories render as expected
  3. Check for any console errors or warnings that need to be addressed

Screenshots/Recordings

Before

before720.mov

After

after720.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@@ -22,6 +22,8 @@ const preview: Preview = {
],
},
},

tags: ['autodocs']
Copy link
Collaborator Author

@georgewrmarshall georgewrmarshall May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 32 to 35
docs: {
autodocs: true,
},

docs: {},
Copy link
Collaborator Author

@georgewrmarshall georgewrmarshall May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs.autodocs setting in .storybook/main.ts is deprecated. Learn more: https://github.com/storybookjs/storybook/blob/next/ MIGRATION.md#mainjs-docsautodocs-is-deprecated

@georgewrmarshall georgewrmarshall changed the title chore: upgrading storybook to 8.1.1 chore: upgrading storybook to 8.1.2 May 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [4f5604b]

Storybook: Storybook

framework: {
name: '@storybook/react-vite',
options: {},
},
docs: {
autodocs: true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

socket-security bot commented May 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@storybook/addon-actions@8.2.0-alpha.2 None 0 59.5 kB shilman
npm/@storybook/addon-backgrounds@8.2.0-alpha.2 None 0 19.4 kB shilman
npm/@storybook/addon-controls@8.2.0-alpha.2 None 0 19.2 kB shilman
npm/@storybook/addon-docs@8.2.0-alpha.2 None 0 2.17 MB shilman
npm/@storybook/addon-essentials@8.2.0-alpha.2 None 0 12.8 kB shilman
npm/@storybook/addon-highlight@8.2.0-alpha.2 None 0 9.36 kB shilman
npm/@storybook/addon-interactions@8.2.0-alpha.2 None 0 12.8 MB shilman
npm/@storybook/addon-links@8.2.0-alpha.2 None 0 19.4 kB shilman
npm/@storybook/addon-measure@8.2.0-alpha.2 None 0 32.4 kB shilman
npm/@storybook/addon-outline@8.2.0-alpha.2 None 0 23.2 kB shilman
npm/@storybook/addon-toolbars@8.2.0-alpha.2 None 0 9.99 kB shilman
npm/@storybook/addon-viewport@8.2.0-alpha.2 None 0 16.6 kB shilman
npm/@storybook/blocks@8.2.0-alpha.2 eval 0 325 kB shilman
npm/@storybook/builder-manager@8.2.0-alpha.2 filesystem 0 57.7 kB shilman
npm/@storybook/builder-vite@8.2.0-alpha.2 environment, filesystem 0 275 kB shilman
npm/@storybook/channels@8.2.0-alpha.2 None 0 24.1 kB shilman
npm/@storybook/cli@8.2.0-alpha.2 Transitive: filesystem, shell +3 1.68 MB shilman
npm/@storybook/client-logger@8.2.0-alpha.2 None 0 7.53 kB shilman
npm/@storybook/codemod@8.2.0-alpha.2 filesystem Transitive: environment, unsafe +3 9 MB shilman
npm/@storybook/components@8.2.0-alpha.2 environment 0 2.97 MB shilman
npm/@storybook/core-common@8.2.0-alpha.2 environment, filesystem, network, unsafe +1 187 kB shilman
npm/@storybook/core-events@8.2.0-alpha.2 None 0 162 kB shilman
npm/@storybook/core-server@8.2.0-alpha.2 environment, filesystem, network 0 1.55 MB shilman
npm/@storybook/csf-plugin@8.2.0-alpha.2 filesystem 0 6.06 kB shilman
npm/@storybook/csf-tools@8.2.0-alpha.2 eval, filesystem 0 46.3 kB shilman
npm/@storybook/docs-tools@8.2.0-alpha.2 None 0 40.3 kB shilman
npm/@storybook/instrumenter@8.2.0-alpha.2 environment 0 209 kB shilman
npm/@storybook/manager-api@8.2.0-alpha.2 environment, network 0 259 kB shilman
npm/@storybook/manager@8.2.0-alpha.2 None 0 2.41 MB shilman
npm/@storybook/node-logger@8.2.0-alpha.2 environment 0 169 kB shilman
npm/@storybook/preview-api@8.2.0-alpha.2 network 0 330 kB shilman
npm/@storybook/preview@8.2.0-alpha.2 eval, network 0 343 kB shilman
npm/@storybook/react-dom-shim@8.2.0-alpha.2 None 0 39 kB shilman
npm/@storybook/react-vite@8.2.0-alpha.2 None 0 12.7 kB shilman
npm/@storybook/react@8.2.0-alpha.2 None 0 107 kB shilman
npm/@storybook/router@8.2.0-alpha.2 environment, eval 0 83.7 kB shilman
npm/@storybook/telemetry@8.2.0-alpha.2 environment, filesystem, network, shell 0 370 kB shilman
npm/@storybook/test@8.2.0-alpha.2 environment, eval 0 1.63 MB shilman
npm/@storybook/theming@8.2.0-alpha.2 environment 0 737 kB shilman
npm/@storybook/types@8.2.0-alpha.2 None 0 111 kB shilman
npm/markdown-to-jsx@7.4.7 None 0 466 kB probablyup
npm/storybook@8.2.0-alpha.2 None 0 1.28 kB shilman

🚮 Removed packages: npm/@storybook/addon-actions@8.1.1, npm/@storybook/addon-backgrounds@8.1.1, npm/@storybook/addon-controls@8.1.1, npm/@storybook/addon-docs@8.1.1, npm/@storybook/addon-essentials@8.1.1, npm/@storybook/addon-highlight@8.1.1, npm/@storybook/addon-interactions@8.1.1, npm/@storybook/addon-links@8.1.1, npm/@storybook/addon-measure@8.1.1, npm/@storybook/addon-outline@8.1.1, npm/@storybook/addon-toolbars@8.1.1, npm/@storybook/addon-viewport@8.1.1, npm/@storybook/blocks@8.1.1, npm/@storybook/builder-manager@8.1.1, npm/@storybook/builder-vite@8.1.1, npm/@storybook/channels@8.1.1, npm/@storybook/cli@8.1.1, npm/@storybook/client-logger@8.1.1, npm/@storybook/codemod@8.1.1, npm/@storybook/components@8.1.1, npm/@storybook/core-common@8.1.1, npm/@storybook/core-events@8.1.1, npm/@storybook/core-server@8.1.1, npm/@storybook/csf-plugin@8.1.1, npm/@storybook/csf-tools@8.1.1, npm/@storybook/docs-tools@8.1.1, npm/@storybook/instrumenter@8.1.1, npm/@storybook/manager-api@8.1.1, npm/@storybook/manager@8.1.1, npm/@storybook/node-logger@8.1.1, npm/@storybook/preview-api@8.1.1, npm/@storybook/preview@8.1.1, npm/@storybook/react-dom-shim@8.1.1, npm/@storybook/react-vite@8.1.1, npm/@storybook/react@8.1.1, npm/@storybook/router@8.1.1, npm/@storybook/telemetry@8.1.1, npm/@storybook/test@8.1.1, npm/@storybook/theming@8.1.1, npm/@storybook/types@8.1.1, npm/markdown-to-jsx@7.3.2, npm/storybook@8.1.1

View full report↗︎

Copy link

socket-security bot commented May 21, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [b85d08e]

Storybook: Storybook

@georgewrmarshall georgewrmarshall marked this pull request as ready for review May 21, 2024 21:55
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner May 21, 2024 21:55
@georgewrmarshall georgewrmarshall merged commit 2179a9c into main May 21, 2024
19 checks passed
@georgewrmarshall georgewrmarshall deleted the upgrade/sb8.1.1 branch May 21, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants