Add TypedDataUtils.hashType tests
#171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends upon #167 |
Gudahtt
force-pushed
the
add-hash-struct-tests
branch
from
e419505
to
16f1b8f
Compare
Gudahtt
force-pushed
the
add-hash-type-tests
branch
from
62e962d
to
d6dbb1b
Compare
Gudahtt
changed the base branch from
add-hash-struct-tests
to
add-encode-type-tests
rekmarks
reviewed
Aug 15, 2021
rekmarks
previously approved these changes
Aug 15, 2021
|
I made the same change as I did in #167, FYI. |
Gudahtt
force-pushed
the
add-hash-type-tests
branch
from
683d551
to
019018d
Compare
|
This has been rebased to resolve conflicts |
This function should now be comprehensively tested. These tests mirror the `TypedDataUtils.encodeType` tests. Any uses of `hashType` in the older signature tests have been removed, as they are now redundant.
Gudahtt
force-pushed
the
add-hash-type-tests
branch
from
019018d
to
f2a2d1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function should now be comprehensively tested. These tests mirror the
TypedDataUtils.encodeTypetests. Any uses ofhashTypein the older signature tests have been removed, as they are now redundant.