Skip to content

Commit

Permalink
fix: CircleCI test-e2e-chrome-confirmation-redesign job (#24684)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

created script to build script with ENABLE_CONFIRMATION_REDESIGN flag
and added to test-e2e-chrome-confirmation-redesign command

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24684?quickstart=1)

## **Related issues**
Fixes: #24712
Fixes: #23975
Continues and related to:
#24240

## **Manual testing steps**

check ci/circleci: test-e2e-chrome-confirmation-redesign job

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Priya Narayanaswamy <priya.narayanaswamy@consensys.net>
  • Loading branch information
digiwand and pnarayanaswamy committed May 24, 2024
1 parent 7bf0b3d commit a156e5e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1010,7 +1010,7 @@ jobs:
command: |
if .circleci/scripts/test-run-e2e.sh
then
timeout 20m yarn test:e2e:chrome --retries 2
timeout 20m yarn test:e2e:chrome:confirmation-redesign --retries 2
fi
no_output_timeout: 5m
environment:
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"test:e2e:mmi:visual": "./test/e2e/mmi/scripts/run-visual-test.sh check",
"test:e2e:mmi:visual:update": "./test/e2e/mmi/scripts/run-visual-test.sh update",
"test:e2e:pw:report": "yarn playwright show-report public/playwright/playwright-reports/html",
"test:e2e:chrome:confirmation-redesign": "ENABLE_CONFIRMATION_REDESIGN=true SELENIUM_BROWSER=chrome node test/e2e/run-all.js",
"test:e2e:chrome:mv3": "ENABLE_MV3=true SELENIUM_BROWSER=chrome node test/e2e/run-all.js",
"test:e2e:chrome:rpc": "SELENIUM_BROWSER=chrome node test/e2e/run-all.js --rpc",
"test:e2e:chrome:multi-provider": "MULTIPROVIDER=true SELENIUM_BROWSER=chrome node test/e2e/run-all.js --multi-provider",
Expand Down
3 changes: 1 addition & 2 deletions test/e2e/tests/confirmations/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export async function scrollAndConfirmAndAssertConfirm (driver: Driver) {
confirmButton.getAttribute('disabled').then((disabled) => {
assert.equal(disabled, true);
});
confirmButton.click();

// scroll to the bottom which enables the confirm button
await driver.clickElement('.confirm-scroll-to-bottom__button');
Expand All @@ -22,7 +21,7 @@ export async function scrollAndConfirmAndAssertConfirm (driver: Driver) {
confirmButton.getAttribute('disabled').then((disabled) => {
assert.equal(disabled, null);
});
confirmButton.click();
await driver.clickElement('[data-testid="confirm-footer-button"]');
}

export function withRedesignConfirmationFixtures (title: string = '', testFunction: Function) {
Expand Down

0 comments on commit a156e5e

Please sign in to comment.