-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CircleCI test-e2e-chrome-confirmation-redesign job #24684
fix: CircleCI test-e2e-chrome-confirmation-redesign job #24684
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## test-e2e-signature-redesign #24684 +/- ##
============================================================
Coverage 66.01% 66.01%
============================================================
Files 1348 1348
Lines 52505 52505
Branches 13498 13498
============================================================
Hits 34656 34656
Misses 17849 17849 ☔ View full report in Codecov by Sentry. |
redesign build tests passed! Thanks for the pair programming session and getting to the bottom of this issue! Great debugging skills @pnarayanaswamy |
Builds ready [d77e66e]
Page Load Metrics (762 ± 579 ms)
Bundle size diffs
|
Description
created script to build script with ENABLE_CONFIRMATION_REDESIGN flag and added to test-e2e-chrome-confirmation-redesign command
Related issues
Fixes: #24712
Fixes: #23975
Continues and related to: #24240
Manual testing steps
check ci/circleci: test-e2e-chrome-confirmation-redesign job
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist