Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CircleCI test-e2e-chrome-confirmation-redesign job #24684

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented May 21, 2024

Description

created script to build script with ENABLE_CONFIRMATION_REDESIGN flag and added to test-e2e-chrome-confirmation-redesign command

Open in GitHub Codespaces

Related issues

Fixes: #24712
Fixes: #23975
Continues and related to: #24240

Manual testing steps

check ci/circleci: test-e2e-chrome-confirmation-redesign job

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand changed the base branch from develop to test-e2e-signature-redesign May 21, 2024 15:29
@digiwand digiwand changed the title Fix test e2e circleci chrome confirmation redesign fix: CircleCI test-e2e-chrome-confirmation-redesign job May 21, 2024
@digiwand digiwand added the team-confirmations Push issues to confirmations team label May 21, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.01%. Comparing base (7bf0b3d) to head (d77e66e).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           test-e2e-signature-redesign   #24684   +/-   ##
============================================================
  Coverage                        66.01%   66.01%           
============================================================
  Files                             1348     1348           
  Lines                            52505    52505           
  Branches                         13498    13498           
============================================================
  Hits                             34656    34656           
  Misses                           17849    17849           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@digiwand
Copy link
Contributor Author

redesign build tests passed! Thanks for the pair programming session and getting to the bottom of this issue! Great debugging skills @pnarayanaswamy

@metamaskbot
Copy link
Collaborator

Builds ready [d77e66e]
Page Load Metrics (762 ± 579 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint622481004220
domContentLoaded8341563
load5033417621206579
domInteractive8341563
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 37 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@digiwand digiwand marked this pull request as ready for review May 24, 2024 13:59
@digiwand digiwand requested review from kumavis and a team as code owners May 24, 2024 13:59
@digiwand digiwand merged commit a156e5e into test-e2e-signature-redesign May 24, 2024
65 of 66 checks passed
@digiwand digiwand deleted the fix-test-e2e-circleci-chrome-confirmation-redesign branch May 24, 2024 13:59
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants