Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask functionality for new Trezor update 2.4.2 #12130

Closed
PleaseHelp123 opened this issue Sep 16, 2021 · 98 comments
Closed

Metamask functionality for new Trezor update 2.4.2 #12130

PleaseHelp123 opened this issue Sep 16, 2021 · 98 comments

Comments

@PleaseHelp123
Copy link

Trezor support for EIP-1559 was updated with firmware update 2.4.2 today.

However, the corresponding functionality on Metamask side is missing.

There is many people who have funds stuck on the Polygon bridge for example because of the missing functionality.

Please solve this ASAP.

@Fraeddy
Copy link

Fraeddy commented Sep 16, 2021

Yes, this needs to be adressed urgently!

@0xGitGuy
Copy link

Please this. EIP 1559 happened 40 days ago and we still can't sign type 2 txn. Could we push this as urgent release?

@mysliwiec-tech
Copy link

Seems there's a demand for it. Wanted to post this issue, but it's already created.

@dpazdan
Copy link

dpazdan commented Sep 17, 2021

The team is reviewing this and working on implementing it in a future update (soon). Stay tuned! 🙏

@Fraeddy
Copy link

Fraeddy commented Sep 18, 2021

for everyone who has funds stuck, follow this guide: https://mobile.twitter.com/DeFi_Dad/status/1429975134178320387

Basically you have to downgrade to an older version of MM before EIP-1559 support was implemented. I have a Trezor and this did the trick for me!

@apotheosic
Copy link

The team is reviewing this and working on implementing it in a future update (soon). Stay tuned! 🙏

any update regarding this issue? Many of us have assets locked up for days now and we would appreciate it if you could resolve it at the earliest.

@gonegoin
Copy link

gonegoin commented Sep 20, 2021

I'm having this problem when using the Send/Deposit function at the website Changenow.io. But it looks like its a general Metamask issue? Not able to use Trezor with Metamask is a major problem

@gonegoin
Copy link

for everyone who has funds stuck, follow this guide: https://mobile.twitter.com/DeFi_Dad/status/1429975134178320387

Basically you have to downgrade to an older version of MM before EIP-1559 support was implemented. I have a Trezor and this did the trick for me!

Wonder if there's a similar workaround for Metamask on Chromium? Just check on Chrome store but couldn't see a way to downgrade

@ghost
Copy link

ghost commented Sep 22, 2021

for everyone who has funds stuck, follow this guide: https://mobile.twitter.com/DeFi_Dad/status/1429975134178320387
Basically you have to downgrade to an older version of MM before EIP-1559 support was implemented. I have a Trezor and this did the trick for me!

Wonder if there's a similar workaround for Metamask on Chromium? Just check on Chrome store but couldn't see a way to downgrade

Nope.... We just have to hope the mm team solves this asap 😭

@justincavery
Copy link

We're seeing complaints come through on NFTX that people can not sell their NFTs through the platform because of an issue very similar to this. It's great to know it's fixed now.

@troydash
Copy link

troydash commented Oct 3, 2021

Really need this for Trezor. If it can't be implemented quickly, at the very least it should be patched to revert to non-EIP1559 for Trezor so that people don't have to downgrade to 9.8.4. Downgrading your metamask as a workaround for anything should generally not be encouraged and that is what is happening...

@0xfarhaan
Copy link

Please could we get an update on the integration please. We can't force legacy transactions on the latest release of metamask as well.

@bretrouse
Copy link

How is this still unassigned?

@FlipsideAUT
Copy link

Its really sad that this is not implemented yet, i could have spent the 200-300usd in eth for bounty which i overpayd the last days with legacy txs from Trezor T...
Please address this asap Metamask!
thanks.

@the-emerald
Copy link

the-emerald commented Oct 13, 2021

+1 on this. Really unfortunate we have to keep overpaying fees!

@0xGitGuy
Copy link

Just want to up the competition so incumbents don't rest on their laurels. There's xdefi wallet that hasn't integrated trezor but soon will. Defi moves fast, 30 days is a lot of time.

@Tmarqu96
Copy link

This is still an ongoing issue and needs to be addressed urgently.

@FiveBoroughs
Copy link

Eip 1559 was released on August 5th, 2 and a half months ago now, mindblowing that the industry's leading wallet still isn't working on supporting it

@0xGitGuy
Copy link

0xGitGuy commented Oct 16, 2021

I think no one is assigned to this. Perhaps try posting here? trezor/connect#874

@kfeldspar
Copy link

kfeldspar commented Oct 17, 2021

I'm getting the same error message, with latest version of MetaMask and Trezor firmware. Very frustrating.

@cmsmith1234
Copy link

I have some CRV stuck on Matic Bridge...Can Metamask please offer proper instructions for downgrading in order to make these transactions go through? I am using a Trezor Hardware wallet and Chrome browser. HELP!!! :-)

@darkwing darkwing added area-hardware hardware-trezor Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels Oct 19, 2021
@FiveBoroughs
Copy link

FiveBoroughs commented Oct 19, 2021

I'll send a bounty of 0.5 Eth to whoever fixes this issue.

Bounty reduces by 0.02Eth a day from 26th October 00:00 UTC (in a week)

@0xGitGuy
Copy link

0xGitGuy commented Oct 19, 2021

Didn't think of this earlier. Not much as earlier guy but i'm adding 0.05 ETH to the bounty pool

@enrbh
Copy link

enrbh commented Oct 19, 2021

Please fix. This is causing me problems too.

@ibai93
Copy link

ibai93 commented Dec 4, 2021

It looks like that PR was merged https://github.com/MetaMask/metamask-extension/pull/12627.
It seems that we are getting closer to get the fix.
Someone know when will be released the new version?

@aloisklink
Copy link
Contributor

It looks like that PR was merged https://github.com/MetaMask/metamask-extension/pull/12627. It seems that we are getting closer to get the fix. Someone know when will be released the new version?

It looks like it's already in the release candidate for v10.8.0:

There's also links to test builds, if you want to manually install the RC and play around with EIP-1559 on an Ethereum test net, (probably best not to risk real money until the official release, though).

Past release candidates seem to have taken about 1-2 weeks to get released, but I don't work for MetaMask, so can't confirm it this one would take the same length.

@prusnak
Copy link

prusnak commented Dec 15, 2021

It seems the Metamask 10.8.0 has been already released. Is this fixed? Should we close the issue?

@jruberto
Copy link

I tried 2 sites (Polygon bridge, and an NFT mint) that both were failing with the EIP-1559 error when using a Trezor on 10.7, and they both seem to work fine now on 10.8.

@danjm
Copy link
Contributor

danjm commented Dec 15, 2021

Thanks everyone for the feedback on this take. Apologies for the long delay. The fix is now released on firefox and chrome with version v10.8.0

Thanks to @aloisklink for their great help on this

I will close this issue. Please add comment below if anyone has further trouble with EIP-1559 transactions on Trezor.

@danjm danjm closed this as completed Dec 15, 2021
@prusnak
Copy link

prusnak commented Dec 15, 2021

Thank you very much @danjm! Much appreciated!

@yurenju
Copy link

yurenju commented Dec 16, 2021

@danjm thanks and could you also update for Edge browser? it is still 10.7.1
https://microsoftedge.microsoft.com/addons/detail/metamask/ejbalbakoplchlghecdalmeeeajnimhm

@aloisklink
Copy link
Contributor

Thank you very much @danjm!

Big thank you to the @trezor team and @danjm for adding Trezor Model T and Trezor Model One support right before v10.8.0 came out!

@notsureofagoodname
Copy link

TY WAGMI! 🚀

@gitcoinbot
Copy link

⚡️ A tip worth 0.25000 ETH (989.01 USD @ $3956.04/ETH) has been granted to @aloisklink for this issue from @FiveBoroughs. ⚡️

Nice work @aloisklink! Your tip has automatically been deposited in the ETH address we have on file.

@gitcoinbot
Copy link

⚡️ A tip worth 0.25000 ETH (989.01 USD @ $3956.04/ETH) has been granted to @danjm for this issue from @FiveBoroughs. ⚡️

Nice work @danjm! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@yurenju
Copy link

yurenju commented Dec 23, 2021

@danjm could you also publish v10.8 for the edge browser? the process should be similar to the chrome/firefox extension, for now, it is still v10.7 for edge.

@scottwalker99
Copy link

scottwalker99 commented Dec 23, 2021 via email

@FiveBoroughs
Copy link

Can ANYONE help me understand how to upgrade my metamask? I have absolutely no idea how to do it… (Running one version on Chrome and one version on Brave.) there are literally zero instructions on how to upgrade.. Thanks Scott

On Dec 22, 2021, at 9:31 PM, Yuren Ju (yurenju) @.***> wrote: @danjm https://github.com/danjm could you also publish v10.8 for the edge browser? the process should be similar to the chrome/firefox extension, for now, it is still v10.7 for edge. — Reply to this email directly, view it on GitHub <#12130 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH6CX3I6FO567HFV4LLY5KDUSJ3YDANCNFSM5EFCN6NQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

chrome://extensions/
Top right side >enable dev mode
Top left side >update exensions
Top right side >disable dev mode

@scottwalker99
Copy link

scottwalker99 commented Dec 23, 2021 via email

@yurenju
Copy link

yurenju commented Dec 27, 2021

sorry to be that annoying but could you also update it for the Edge browser? it is still 10.7.1 which is not supported eip-1559, maybe @danjm @darkwing @mcmire
since the edge extension should be the same as the chrome extension, simply update that can solve the problem!

https://microsoftedge.microsoft.com/addons/detail/metamask/ejbalbakoplchlghecdalmeeeajnimhm

@leglinne
Copy link

Thanks everyone for the feedback on this take. Apologies for the long delay. The fix is now released on firefox and chrome with version v10.8.0

Thanks to @aloisklink for their great help on this

I will close this issue. Please add comment below if anyone has further trouble with EIP-1559 transactions on Trezor.

Hi, the issue is still present in my case

Yesterday i transferred nft from my metamask wallet to trezor using MM interface, it's on poly network via opensea

ERC-1155 standard

as far as i could read it is possible and transferrable, yet opensea gives me an error when im trying to unlock my currency

metamask just doesn't send this transaction to my trezor even when i try to transfer it back to my previous wallet, saying that i declined it on my wallet, but there was no transaction shown

only relevant post i found was on metamask github
#13103

Console is giving me this error code :

inpage.js:1 MetaMask - RPC Error: MetaMask Message Signature: Error: Not supported on this device {code: -32603,

@prusnak
Copy link

prusnak commented Dec 29, 2021

@leglinne are you on the latest version of metamask? (10.8.0)

@leglinne
Copy link

@leglinne are you on the latest version of metamask? (10.8.0)

I'm on the latest trezor hardware and on the latest MM version (10.8.1)
Also I have sufficient MATIC tokens to make any transaction

@aloisklink
Copy link
Contributor

@leglinne, my gut feeling is that this is due to a different issue, #11498, but I've never used OpenSea on Polygon/MATIC so I can't confirm if they are using EIP-712 typed signing.

@scottwalker99, you're welcome to tip anybody's GitHub account using https://gitcoin.co/tip. FYI, my contributions were before any bounty was announced, so I'm not expecting anything, but I wouldn't say no to free money.

@leglinne
Copy link

@leglinne, my gut feeling is that this is due to a different issue, #11498, but I've never used OpenSea on Polygon/MATIC so I can't confirm if they are using EIP-712 typed signing.

Trezor did add the functionality of the EIP-712 signing standard in their latest firmware update , as can be seen in their blogpost

I've already contacted MM support on this case yesterday, they told me that this is the issue with the MM to Trezor integration , so I've been led to thinking that this is a bug on MM side.

@danjm
Copy link
Contributor

danjm commented Jan 6, 2022

@scottwalker99 If you want to send a tip, @aloisklink is the one to send to! :)

@danjm
Copy link
Contributor

danjm commented Jan 6, 2022

@leglinne You are experiencing a separate issue from the EIP-1559 support on Trezor. We suspect it has something to do with polygon on opensea specifically. We will try to investigate this very soon

@danjm
Copy link
Contributor

danjm commented Jan 6, 2022

For folks asking about the Edge browser: Edge is often very slow to accept a new version submission and release the updated version. Hopefully that update will happen soon.

@scottwalker99
Copy link

scottwalker99 commented Jan 6, 2022 via email

@samuveth
Copy link

samuveth commented Jan 7, 2022

On Snapshot we are still experiencing issues when signing with Trezor Model T and Metamask.

Our users are getting the following error in the browser console: MetaMask Message Signature: Error: Not supported on this device

Firmware 2.4.3
Metamask 10.8.1
Chrome Version 96.0.4664.110

You can test it by voting on this proposal (no onchain tx required) https://snapshot.org/#/samuv.eth/proposal/0x4baee15b67948224f4b0a5e61584fd529ccae8ccb6198c38496479408b93c8e1

@aloisklink
Copy link
Contributor

aloisklink commented Jan 9, 2022

On Snapshot we are still experiencing issues when signing with Trezor Model T and Metamask.

Hi @samuveth, I'm having the same issue with snapshot, and it's due to another issue, #11498.

EDIT: Nevermind, I just saw you already linked to that issue, so you're already aware of it 😄

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests