Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tx's are not updated to the last Recipient or tx Type, if I replace them using the same nonce, causing a missmatch between Etherscan & what MM displays #15632

Closed
seaona opened this issue Aug 18, 2022 · 6 comments
Labels
area-activity Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-assets type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Aug 18, 2022

Describe the bug

Problem: when I update a tx from the Queue (being a Send or a Contract deployment) I can see that the data is not updated and the tx displays the old receiver, even though I've updated the receiver, or even change the tx for a Contract deployment

  • Example changing the receiver and not updating (you can see the missmatch with Etherscan)
replacement-tx-not-updated-2.mp4
  • Example changing the Send tx for a Contract deployment (you can see the contract deployment on Etherscan, whereas on MM is displayed as a regular Send to the old receiver)
replacement-tx-not-updated.mp4

Steps to reproduce

  1. Unlock MM
  2. Enable Modify Nonce from Settings
  3. Click Send
  4. Modify Nonce and include the default nonce +1
  5. Set Low gas fees
  6. Confirm tx
  7. Perform another tx, now change the recipient (or deploy a contract)
  8. Modify Nonce being the same as 4
  9. Set Aggressive gas fees and proceed
  10. Click Send
  11. Perform any tx with default nonce
  12. Wait for all tx's to be confirmed
  13. Check tx details from 3, and check Etherscan details (See difference)

Error messages or log output

No response

Version

10.19.0

Build type

No response

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

@bschorchit bschorchit added Sev2-normal Normal severity; minor loss of service or inconvenience. area-transactions labels Aug 18, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 20, 2023
@bschorchit bschorchit added team-confirmations-planning (only for internal use within Confirmations team) area-activity and removed stale issues and PRs marked as stale labels Jul 20, 2023
@bschorchit
Copy link

We don't want this to be closed :)

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Oct 19, 2023
Copy link
Contributor

github-actions bot commented Dec 3, 2023

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2023
@seaona seaona removed the stale issues and PRs marked as stale label Mar 6, 2024
@seaona seaona reopened this Mar 6, 2024
@bschorchit bschorchit added team-assets and removed area-transactions team-confirmations-planning (only for internal use within Confirmations team) labels May 29, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Aug 27, 2024
Copy link
Contributor

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-activity Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-assets type-bug
Projects
Archived in project
Development

No branches or pull requests

2 participants