[Bug]: Long Account Names Not Ellipsized in Account Picker #23095
Labels
Comments
darkwing
added a commit
that referenced
this issue
Feb 21, 2024
13 tasks
darkwing
added a commit
that referenced
this issue
Feb 22, 2024
## **Description** Fixes long account name ellipsizing in the header's AccountPicker. [](https://codespaces.new/MetaMask/metamask-extension/pull/23096?quickstart=1) ## **Related issues** Fixes: #23095 23095 ## **Manual testing steps** 1. Create a long account name 2. See it ellipsized ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before**  ### **After** <img width="725" alt="SCR-20240221-kvri" src="https://github.com/MetaMask/metamask-extension/assets/46655/9c42a0f2-ba7d-40af-b588-2c4bf3b04d55"> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-11.12.0
dbrans
pushed a commit
that referenced
this issue
Feb 27, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/23096?quickstart=1){kind=link}
## **Description** Fixes long account name ellipsizing in the header's AccountPicker. [](https://codespaces.new/MetaMask/metamask-extension/pull/23096?quickstart=1) ## **Related issues** Fixes: #23095 23095 ## **Manual testing steps** 1. Create a long account name 2. See it ellipsized ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before**  ### **After** <img width="725" alt="SCR-20240221-kvri" src="https://github.com/MetaMask/metamask-extension/assets/46655/9c42a0f2-ba7d-40af-b588-2c4bf3b04d55"> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Long account names aren't being ellipsized in the header. Occurs due to 0b52d3d
Expected behavior
Long account names should be ellipsized.
Screenshots/Recordings
Steps to reproduce
Create account with very long name
Error messages or log output
No response
Version
develop
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: