Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #23095 - Fix long account name ellipsizing #23096

Merged
merged 2 commits into from Feb 22, 2024
Merged

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Feb 21, 2024

Description

Fixes long account name ellipsizing in the header's AccountPicker.

Open in GitHub Codespaces

Related issues

Fixes: #23095 23095

Manual testing steps

  1. Create a long account name
  2. See it ellipsized

Screenshots/Recordings

Before

Screenshot 2024-02-21 at 16 06 43

After

SCR-20240221-kvri

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner February 21, 2024 18:00
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Feb 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [9813e27]
Page Load Metrics (1802 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint9171721414067
domContentLoaded981372211
load15722290180215172
domInteractive981372211
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 22 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing merged commit 1cc451c into develop Feb 22, 2024
65 of 66 checks passed
@darkwing darkwing deleted the fix-long-accountpicker branch February 22, 2024 16:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Long Account Names Not Ellipsized in Account Picker
5 participants