Improve flashing behaviour for loading gas estimates (on confirm screen) #11852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ryanml
reviewed
Aug 16, 2021
| /> | ||
| <div className="confirm-page-container-content__currency-container"> | ||
| {process.env.IN_TEST === 'true' ? null : ( | ||
| <LoadingHeartBeat ttt /> |
ryanml
reviewed
Aug 16, 2021
| key="editGasSubTextFeeValue" | ||
| className="confirm-page-container-content__currency-container" | ||
| > | ||
| {process.env.IN_TEST === 'true' ? null : <LoadingHeartBeat />} |
There was a problem hiding this comment.
nit: Only if you need to push again, could we maybe capture this in a method? (maybeRenderHeartBeat)
darkwing
previously approved these changes
Aug 16, 2021
danjm
force-pushed
the
fix-flashing-behaviour
branch
from
1365ef4
to
3e0ec87
Compare
Builds ready [3592881]
Page Load Metrics (644 ± 14 ms)
|
ryanml
approved these changes
Aug 16, 2021
darkwing
approved these changes
Aug 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few improvements to the flashing estimates on the confirm screen.
When paired with my other PR, it looks like this:
maticloadinggasfix.mp4