Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Use Token detection to OFF by default #12129

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

NiranjanaBinoy
Copy link
Contributor

This is part of #12128

We are keeping the token detection OFF by default so that the users can opt-in based on their network and helps us to get early feedback reducing the risk of shipping any regression to our whole user base.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NiranjanaBinoy NiranjanaBinoy changed the title Chaning Use Token detection to OFF by default Changing Use Token detection to OFF by default Sep 16, 2021
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [d4df1be]
Page Load Metrics (286 ± 23 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint543752578139
domContentLoaded2283642704823
load2413962864923
domInteractive2283642704823

@NiranjanaBinoy NiranjanaBinoy merged commit 66c3414 into develop Sep 16, 2021
@NiranjanaBinoy NiranjanaBinoy deleted the token-detection-off branch September 16, 2021 17:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants