-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue where regional locales are not matched against our locales list #12403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adonesky1
force-pushed
the
fix-init-locale
branch
from
October 19, 2021 16:01
5c960aa
to
baada80
Compare
Gudahtt
reviewed
Oct 19, 2021
Builds ready [baada80]
Page Load Metrics (397 ± 42 ms)
|
Gudahtt
reviewed
Oct 19, 2021
adonesky1
force-pushed
the
fix-init-locale
branch
from
October 19, 2021 18:20
adb2bd1
to
cf2d85d
Compare
adonesky1
force-pushed
the
fix-init-locale
branch
from
October 19, 2021 18:21
cf2d85d
to
7102ee9
Compare
Gudahtt
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [7102ee9]
Page Load Metrics (390 ± 42 ms)
|
jpuri
approved these changes
Oct 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12353
Explanation: Some users experience issues in onboarding if their browsers' language settings are set such that their primary language is coded regionally, and another secondary language - for which we have translations - is not. Before this PR we were not normalizing regionally coded language settings to their base (e.g. 'en-us' => 'en') if we didn't have that regional coding in our translations. This PR adds this normalization.
Manual testing steps: