Tx insights fixes #12988
Merged
Tx insights fixes #12988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [dff5c16]Page Load Metrics (1174 ± 82 ms)
highlights:storybook
|
darkwing
requested changes
Dec 6, 2021
ui/components/app/transaction-list-item-details/transaction-list-item-details.component.js
Outdated
Show resolved
Hide resolved
darkwing
previously approved these changes
Dec 6, 2021
Builds ready [bad0de1]Page Load Metrics (935 ± 10 ms)
highlights:storybook
|
georgewrmarshall
previously approved these changes
Dec 7, 2021
There was a problem hiding this comment.
LGTM! Read through doc and have tested that:
- Empty activity log is hidden on receive transaction ✅
- Correct method name shown ✅
- Cursor is not pointer on error messages
cursor.1.mov
cursor.2.mov
danjm
dismissed stale reviews from georgewrmarshall, adonesky1, and darkwing
via
dc0a615
|
@darkwing @georgewrmarshall @adonesky1 I just pushed one more commit that fixes the last issue to do with transaction insights "Swaps and Simple Send txs have 404 error code in Transaction Data in Tx details." |
darkwing
approved these changes
Dec 7, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues Dec 2: 1, 2 and 3, and Dec 6: 5 and 6, in the v10.8.0 RC doc