Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLASK] Allow snaps insights to show on regular EOA transactions #16093

Merged
merged 1 commit into from Oct 26, 2022
Merged

[FLASK] Allow snaps insights to show on regular EOA transactions #16093

merged 1 commit into from Oct 26, 2022

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Oct 5, 2022 •
edited by FrederikBolding

Explanation

Allow regular EOA transactions to display Snap TX insights on confirmation screen.

Manual Testing Steps

Fixes MetaMask/snaps#805

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner October 5, 2022 16:09
GuillaumeRx
GuillaumeRx commented Oct 5, 2022
View reviewed changes
...rm-page-container/confirm-page-container-content/confirm-page-container-content.component.js
Comment on lines +105 to +109
{dataComponent && (
<Tab className="confirm-page-container-content__tab" name={t('data')}>
{dataComponent}
</Tab>
)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix a bug that would show the dataComponent even if no component was provided

@Montoya
Copy link
Contributor

Montoya commented Oct 5, 2022

This solves #805

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@GuillaumeRx GuillaumeRx force-pushed the gr/add-snaps-insight-to-regular-tx branch from 79185b2 to 48c82a4 Compare October 5, 2022 17:44
@metamaskbot
Copy link
Collaborator

Builds ready [48c82a4]
Page Load Metrics (2534 ± 136 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint108179128199
domContentLoaded200831652497284136
load200931862534284136
domInteractive200831652497284136

highlights:

storybook

@GuillaumeRx GuillaumeRx force-pushed the gr/add-snaps-insight-to-regular-tx branch from 48c82a4 to 5f87a44 Compare October 6, 2022 15:34
@metamaskbot
Copy link
Collaborator

Builds ready [5f87a44]
Page Load Metrics (2442 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint922281192914
domContentLoaded21692918243016981
load22092918244216378
domInteractive21692918243016981

highlights:

storybook

@FrederikBolding FrederikBolding merged commit cf265ed into develop Oct 26, 2022
@FrederikBolding FrederikBolding deleted the gr/add-snaps-insight-to-regular-tx branch October 26, 2022 09:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkwing darkwing darkwing left review comments

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@hmalik88 hmalik88 hmalik88 approved these changes

Assignees
No one assigned
Labels
flask
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tx-insights for transactions between EOAs
6 participants
@GuillaumeRx @Montoya @metamaskbot @darkwing @FrederikBolding @hmalik88