NFTs: Remove feature flag for release #17401

darkwing · 2023-01-24T23:28:00Z

Explanation

Removes the feature flag for the NFT feature.

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-01-24T23:28:15Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-01-25T21:17:28Z

Builds ready [4fa1747]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1538 ± 111 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	101	244	144	37	18
		domContentLoaded	1201	1912	1503	226	109
		load	1201	1932	1538	232	111
		domInteractive	1201	1912	1503	226	109

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 679 bytes
ui: 2999 bytes
common: 0 bytes

metamaskbot · 2023-01-30T19:04:54Z

Builds ready [a617baf]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1366 ± 103 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	103	161	135	16	7
		domContentLoaded	1012	1850	1327	214	103
		load	1029	1927	1366	215	103
		domInteractive	1012	1850	1327	214	103

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 679 bytes
ui: 2999 bytes
common: 0 bytes

brad-decker · 2023-02-03T21:32:33Z

Needs rebase and then i'll reapprve

metamaskbot · 2023-02-08T21:21:08Z

Builds ready [8e36317]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1353 ± 133 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	164	118	20	9
		domContentLoaded	962	1833	1322	278	134
		load	993	1833	1353	277	133
		domInteractive	962	1833	1322	278	134

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 679 bytes
ui: 1120 bytes
common: 0 bytes

codecov-commenter · 2023-02-08T21:21:42Z

Codecov Report

Merging #17401 (ca0d7ef) into develop (11c79dd) will increase coverage by 0.03%.
The diff coverage is 88.89%.

@@             Coverage Diff             @@
##           develop   #17401      +/-   ##
===========================================
+ Coverage    63.92%   63.95%   +0.03%     
===========================================
  Files          908      908              
  Lines        35398    35391       -7     
  Branches      8974     8966       -8     
===========================================
+ Hits         22627    22633       +6     
+ Misses       12771    12758      -13

Impacted Files	Coverage Δ
ui/helpers/constants/settings.js	`33.78% <ø> (+1.35%)`	⬆️
ui/pages/home/home.component.js	`0.00% <0.00%> (ø)`
ui/pages/routes/routes.component.js	`0.00% <ø> (ø)`
...ngs/experimental-tab/experimental-tab.component.js	`56.76% <ø> (+9.39%)`	⬆️
app/scripts/metamask-controller.js	`61.89% <100.00%> (+0.22%)`	⬆️
...i/components/app/wallet-overview/token-overview.js	`58.33% <100.00%> (ø)`
ui/ducks/send/send.js	`77.96% <100.00%> (ø)`
ui/pages/import-token/import-token.component.js	`71.43% <100.00%> (-0.16%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

metamaskbot · 2023-03-04T00:24:22Z

Builds ready [02a7e49]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2001 ± 282 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	341	162	82	39
		domContentLoaded	1417	3086	1970	581	279
		load	1417	3133	2001	588	282
		domInteractive	1416	3086	1970	581	279

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 679 bytes
ui: 1207 bytes
common: 0 bytes

adonesky1 · 2023-03-10T15:25:18Z

I'm seeing a few lingering instances of NFTS_V1 on this branch:

adonesky1 · 2023-03-10T17:37:56Z

Is there still an experimental settings tab?

Screen.Recording.2023-03-10.at.11.37.24.AM.mov

metamaskbot · 2023-03-10T22:03:48Z

Builds ready [ca0d7ef]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1606 ± 72 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	148	121	15	7
		domContentLoaded	1430	2131	1582	154	74
		load	1430	2131	1606	149	72
		domInteractive	1429	2131	1582	154	74

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 679 bytes
ui: 896 bytes
common: 0 bytes

darkwing · 2023-03-13T15:08:39Z

I'm seeing a few lingering instances of NFTS_V1 on this branch:

Good shout -- those had been added after this PR had been filed.

Is there still an experimental settings tab?

Yep, it's there.

darkwing added DO-NOT-MERGE Pull requests that should not be merged area-NFTs labels Jan 24, 2023

darkwing requested review from a team and kumavis as code owners January 24, 2023 23:28

darkwing requested a review from hmalik88 January 24, 2023 23:28

darkwing force-pushed the unleash-nfts branch 2 times, most recently from ee3457d to 4fa1747 Compare January 25, 2023 20:51

pedronfigueiredo previously approved these changes Jan 31, 2023

View reviewed changes

brad-decker previously approved these changes Feb 3, 2023

View reviewed changes

darkwing dismissed stale reviews from brad-decker and pedronfigueiredo via b399767 February 3, 2023 22:33

darkwing force-pushed the unleash-nfts branch 2 times, most recently from bab1919 to f01a796 Compare February 8, 2023 18:49

darkwing mentioned this pull request Feb 14, 2023

Adding NFT autodetection to "What's New" Announcements #17653

Merged

8 tasks

darkwing force-pushed the unleash-nfts branch 2 times, most recently from 0bd6eb3 to 02a7e49 Compare March 3, 2023 23:55

PeterYinusa mentioned this pull request Mar 8, 2023

Move nft e2e tests to main e2e test job #18055

Merged

8 tasks

darkwing added 4 commits March 10, 2023 11:47

NFTs: Remove feature flag for release

919cbb2

Update security tab jest test

4b78c52

Fix broken test

8fc3cab

Update snapshot

b81fa8d

darkwing added 3 commits March 10, 2023 11:47

Update test

4c497c2

Fix test

f05015e

Remove last usages of flag

3e256a2

darkwing force-pushed the unleash-nfts branch from 02a7e49 to 3e256a2 Compare March 10, 2023 17:52

darkwing requested a review from a team as a code owner March 10, 2023 17:52

Update CI jobs

27d15e1

darkwing force-pushed the unleash-nfts branch from 7ec79e2 to 27d15e1 Compare March 10, 2023 18:02

Fix jest tests

ca0d7ef

vthomas13 approved these changes Mar 13, 2023

View reviewed changes

NidhiKJha approved these changes Mar 13, 2023

View reviewed changes

darkwing added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Mar 13, 2023

kumavis approved these changes Mar 13, 2023

View reviewed changes

darkwing removed the DO-NOT-MERGE Pull requests that should not be merged label Mar 13, 2023

darkwing merged commit 5b1b5dc into develop Mar 13, 2023

darkwing deleted the unleash-nfts branch March 13, 2023 19:29

github-actions bot locked and limited conversation to collaborators Mar 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NFTs: Remove feature flag for release #17401

NFTs: Remove feature flag for release #17401

darkwing commented Jan 24, 2023 •

edited

Loading

github-actions bot commented Jan 24, 2023

metamaskbot commented Jan 25, 2023

metamaskbot commented Jan 30, 2023

brad-decker commented Feb 3, 2023

metamaskbot commented Feb 8, 2023

codecov-commenter commented Feb 8, 2023 •

edited by codecov bot

Loading

metamaskbot commented Mar 4, 2023

adonesky1 commented Mar 10, 2023

adonesky1 commented Mar 10, 2023

metamaskbot commented Mar 10, 2023

darkwing commented Mar 13, 2023

NFTs: Remove feature flag for release #17401

NFTs: Remove feature flag for release #17401

Conversation

darkwing commented Jan 24, 2023 • edited Loading

Explanation

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 24, 2023

metamaskbot commented Jan 25, 2023

metamaskbot commented Jan 30, 2023

brad-decker commented Feb 3, 2023

metamaskbot commented Feb 8, 2023

codecov-commenter commented Feb 8, 2023 • edited by codecov bot Loading

Codecov Report

metamaskbot commented Mar 4, 2023

adonesky1 commented Mar 10, 2023

adonesky1 commented Mar 10, 2023

metamaskbot commented Mar 10, 2023

darkwing commented Mar 13, 2023

darkwing commented Jan 24, 2023 •

edited

Loading

codecov-commenter commented Feb 8, 2023 •

edited by codecov bot

Loading